[osgearth] Fix undefined references due to openjp2 and xml2#17993
Merged
strega-nil-ms merged 3 commits intomicrosoft:masterfrom Jun 9, 2021
Merged
[osgearth] Fix undefined references due to openjp2 and xml2#17993strega-nil-ms merged 3 commits intomicrosoft:masterfrom
strega-nil-ms merged 3 commits intomicrosoft:masterfrom
Conversation
NancyLi1013
added
the
category:port-bug
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Thanks for fixing this problem. Can you run |
NancyLi1013
approved these changes
May 19, 2021
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@NancyLi1013 , Thanks for updating the PR . Looks all green now. |
Contributor
|
I try to build After added xml2 to the fix-dependency-osg.patch, then rebuild, the errors which are related with Seems it also needs to link |
Contributor
|
Can you post the error you encountered on your machine before you fix the dependent patch? @ankurverma85 |
Contributor
|
@NancyLi1013 This is also from gdal. |
JackBoosY
suggested changes
May 21, 2021
JackBoosY
approved these changes
May 21, 2021
JackBoosY
added
info:needs-maintainer-attention
Contributor
Author
|
pasting the errors I'm seeing |
Contributor
|
Thanks for your details. But I still have one question here. I didn't encounter |
Contributor
Did you build for x64-linux (static linkage)? |
Contributor
|
Thanks for your quick reply @dg0yt.
I build the default triplet, so it should be static linkage.
I actually have installed
I didn't do any changes for |
Contributor
#9068 and most of my PRs...
It is, normally. Still, gdal must export its usage requirements. |
Contributor
Author
|
@NancyLi1013 Regarding gdal issues in general: I think we can all agree this PR isn't the long term correct fix. What @dg0yt is highlighting is completely valid and perhaps his PR is the right direction in terms of a long term fix. |
Contributor
|
Thanks for your details and conclusion @ankurverma85. As talked above, there are many problems in @dg0yt thanks for your help and looking into this. |
NancyLi1013
added
the
info:needs-maintainer-attention
Contributor
Author
|
@NancyLi1013 . This has been lying without merge for a week now |
Contributor
|
Cool, thanks y'all :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add additional dependencies (for GDAL) openjp2 and xml2 in the explicit linking list
What does your PR fix?
Fixes [osgearth] build failure with x64-linux unresolved references #17992 17992
Which triplets are supported/not supported? Have you updated the CI baseline?
Yes
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/