Skip to content

[vcpkg] Move x-ci-verify-versions tests into the "formatting" tests.#17646

Closed
BillyONeal wants to merge 1 commit intomicrosoft:masterfrom
BillyONeal:move-version-check-to-formatting
Closed

[vcpkg] Move x-ci-verify-versions tests into the "formatting" tests.#17646
BillyONeal wants to merge 1 commit intomicrosoft:masterfrom
BillyONeal:move-version-check-to-formatting

Conversation

@BillyONeal
Copy link
Member

(Note that previously this was done in a later step because bootstrap was more expensive; now that bootstrap just downloads a vcpkg.exe we can report problems to the user earlier)

This is to avoid cases where a version update triggers full-rebuild like situations like occurred in #17431

(Note that previously this was done in a later step because bootstrap was more expensive; now that bootstrap just downloads a vcpkg.exe we can report problems to the user earlier)
@BillyONeal BillyONeal requested a review from vicroms May 3, 2021 22:08
@BillyONeal BillyONeal added category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal labels May 3, 2021
@PhoebeHui PhoebeHui changed the title Move x-ci-verify-versions tests into the "formatting" tests. [vcpkg] Move x-ci-verify-versions tests into the "formatting" tests. May 6, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillyONeal
Copy link
Member Author

After some discussion we've decided this is a bad plan, closing.

@BillyONeal BillyONeal closed this May 7, 2021
@BillyONeal BillyONeal deleted the move-version-check-to-formatting branch July 14, 2021 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:infrastructure Pertaining to the CI/Testing infrastrucutre

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants