Conversation
JonLiu1993
left a comment
There was a problem hiding this comment.
Please change the function "vcpkg_fixup_cmake_targets(CONFIG_PATH lib/cmake/pe-parse TARGET_PATH share/pe-parse)" to "vcpkg_fixup_cmake_targets(CONFIG_PATH lib/cmake/pe-parse )" in the portfile.cmake
JonLiu1993
left a comment
There was a problem hiding this comment.
Please change the function "file(INSTALL "${SOURCE_PATH}/LICENSE" DESTINATION "${CURRENT_PACKAGES_DIR}/share/pe-parse" RENAME copyright )" to "${SOURCE_PATH}/LICENSE" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}" RENAME copyright )"
|
@woodruffw, after modifying the requested changes, please run the command "./vcpkg x-add-version pe-pare --overwrite-version", and then submit again. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@woodruffw, thanks for your contribution! The CI test failed with following failures, could you please take a look? pe-parse:arm64-windows: uthenticode with x86-windows, x64-windows, x64-windows-static, x64-linux and x64-osx: |
|
Sure, will do. Sorry for the delay earlier. |
|
@woodruffw, If this pr cannot be solved temporarily, please switch to draft. |
|
Ping @woodruffw for response, Is work still being done for this PR? |
Required for compatibility with pe-parse 1.3.0.
cc12ed8 to
11592b9
Compare
I think it should be good to go -- the dependency that needed a newer version of pe-parse should also be correctly updated. |
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout a863c84812089836a3c0f2f215ab3e2579fc8acf -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index 23329bd..28e09b5 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4857,7 +4857,7 @@
"port-version": 0
},
"pe-parse": {
- "baseline": "1.2.0",
+ "baseline": "1.3.0",
"port-version": 0
},
"pegtl": {
@@ -6533,7 +6533,7 @@
"port-version": 0
},
"uthenticode": {
- "baseline": "1.0.4",
+ "baseline": "1.0.6",
"port-version": 0
},
"uvatlas": {
diff --git a/versions/p-/pe-parse.json b/versions/p-/pe-parse.json
index 7417efa..6f032d5 100644
--- a/versions/p-/pe-parse.json
+++ b/versions/p-/pe-parse.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "0dacc6f1ebace15cd10c5b337595adda545ba691",
+ "version-string": "1.3.0",
+ "port-version": 0
+ },
{
"git-tree": "b26d3371c165c5888f2aca0c7c63107fa2ea1fdc",
"version-string": "1.2.0",
diff --git a/versions/u-/uthenticode.json b/versions/u-/uthenticode.json
index bc6b140..c0d36f6 100644
--- a/versions/u-/uthenticode.json
+++ b/versions/u-/uthenticode.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "af395e82b91ef75c1b320286fc3b6767b2aac225",
+ "version-string": "1.0.6",
+ "port-version": 0
+ },
{
"git-tree": "be0c3da6f7d93aa3a5252b03adc09ffa8105eaf8",
"version-string": "1.0.4",There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout a863c84812089836a3c0f2f215ab3e2579fc8acf -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index 8cadbc5..581b9d3 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4869,7 +4869,7 @@
"port-version": 0
},
"pe-parse": {
- "baseline": "1.2.0",
+ "baseline": "1.3.0",
"port-version": 0
},
"pegtl": {
@@ -6545,7 +6545,7 @@
"port-version": 0
},
"uthenticode": {
- "baseline": "1.0.4",
+ "baseline": "1.0.6",
"port-version": 0
},
"uvatlas": {
diff --git a/versions/p-/pe-parse.json b/versions/p-/pe-parse.json
index 7417efa..6f032d5 100644
--- a/versions/p-/pe-parse.json
+++ b/versions/p-/pe-parse.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "0dacc6f1ebace15cd10c5b337595adda545ba691",
+ "version-string": "1.3.0",
+ "port-version": 0
+ },
{
"git-tree": "b26d3371c165c5888f2aca0c7c63107fa2ea1fdc",
"version-string": "1.2.0",
diff --git a/versions/u-/uthenticode.json b/versions/u-/uthenticode.json
index bc6b140..c0d36f6 100644
--- a/versions/u-/uthenticode.json
+++ b/versions/u-/uthenticode.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "af395e82b91ef75c1b320286fc3b6767b2aac225",
+ "version-string": "1.0.6",
+ "port-version": 0
+ },
{
"git-tree": "be0c3da6f7d93aa3a5252b03adc09ffa8105eaf8",
"version-string": "1.0.4",|
@woodruffw ,Sorry, I accidentally closed your pr and reopened it now. I submitted an update of the same pr #18766 pe-parse port. I have closed my pr. If you encounter difficulties in updating, we can solve it together. |
|
@woodruffw, thanks for your updates! Could you merge some changes from #18766? |
|
Ping @woodruffw for response, is work still being done for this PR? |
|
Sorry, I haven't had the bandwidth to keep up with this. I'll close and reopen when I've got more free time. |
This bumps the
pe-parsepackage to its latest release (1.3.0).What does your PR fix?
Bumps
pe-parse.Which triplets are supported/not supported? Have you updated the [CI baseline]
No changes (all but
uwp).Does your PR follow the maintainer guide?
Yes.
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes.