Skip to content

[libqcow] Fix build issues by updating to 20210419#17525

Merged
strega-nil-ms merged 1 commit intomicrosoft:masterfrom
AlexAltea:libqcow-update
Apr 30, 2021
Merged

[libqcow] Fix build issues by updating to 20210419#17525
strega-nil-ms merged 1 commit intomicrosoft:masterfrom
AlexAltea:libqcow-update

Conversation

@AlexAltea
Copy link
Contributor

@AlexAltea AlexAltea commented Apr 27, 2021

The author behind https://github.com/libyal/libqcow has removed tags/releases that we needed to successfully build on Windows, since the releases contained headers pre-configured for Windows that are not present in the master branch.

This PR solves the issue by bumping to the latest version.

@AlexAltea AlexAltea changed the title [libqcow] Fix build issues by update to 20210419 [libqcow] Fix build issues by updating to 20210419 Apr 27, 2021
@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 27, 2021
NancyLi1013
NancyLi1013 suggested changes Apr 27, 2021
View reviewed changes
@AlexAltea
Copy link
Contributor Author

AlexAltea commented Apr 27, 2021

Applied changes.

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Apr 28, 2021

gdk-pixbuf will be fixed in PR #17528.

But for libqcom, seems you forgot to update version files via vcpkg x-add-version libqcow.

Error: While reading versions for port libqcow from file: C:\a\1\s\versions\l-\libqcow.json
       Version `20210419` was not found in versions file.
       Run:

           vcpkg x-add-version libqcow

       to add the new port version.

Please run vcpkg x-add-version libqcow and then submit the changes.

@AlexAltea
Copy link
Contributor Author

AlexAltea commented Apr 28, 2021

Done. Thanks for your help!

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Apr 29, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 29, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Apr 30, 2021
@strega-nil-ms
Copy link
Contributor

strega-nil-ms commented Apr 30, 2021

Thanks @AlexAltea :)

@strega-nil-ms strega-nil-ms merged commit f3619bd into microsoft:master Apr 30, 2021
@VelocityRa VelocityRa mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexAltea @NancyLi1013 @strega-nil-ms