Skip to content

[vcpkg baseline][marble] Disable dependency KF5#17492

Merged
BillyONeal merged 4 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix_baseline_20210425
Apr 28, 2021
Merged

[vcpkg baseline][marble] Disable dependency KF5#17492
BillyONeal merged 4 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix_baseline_20210425

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Apr 25, 2021 •
edited
Loading

Re-fix issue:

CMake Error at D:/downloads/tools/cmake-3.19.2-windows/cmake-3.19.2-win32-x86/share/cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:218 (message):
  Could NOT find Gettext (missing: GETTEXT_MSGMERGE_EXECUTABLE
  GETTEXT_MSGFMT_EXECUTABLE)
Call Stack (most recent call first):
  D:/downloads/tools/cmake-3.19.2-windows/cmake-3.19.2-win32-x86/share/cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:582 (_FPHSA_FAILURE_MESSAGE)
  D:/downloads/tools/cmake-3.19.2-windows/cmake-3.19.2-win32-x86/share/cmake-3.19/Modules/FindGettext.cmake:81 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package)
  D:/installed/x64-windows/share/kf5i18n/KF5I18nMacros.cmake:5 (find_package)
  D:/installed/x64-windows/share/kf5i18n/KF5I18nConfig.cmake:33 (include)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package)
  D:/installed/x64-windows/share/ECM/find-modules/FindKF5.cmake:53 (find_package)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package)
  MarbleMacros.cmake:124 (find_package)
  src/apps/marble-kde/CMakeLists.txt:14 (macro_optional_find_package)

Related: #13100

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Apr 25, 2021
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Apr 25, 2021 •
edited
Loading

Works. Now revert test code.

@JackBoosY JackBoosY requested a review from PhoebeHui April 25, 2021 04:04
@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 25, 2021
@Hoikas Hoikas mentioned this pull request Apr 26, 2021
Merged
@JackBoosY JackBoosY mentioned this pull request Apr 28, 2021
Merged
@BillyONeal BillyONeal merged commit ee8c444 into microsoft:master Apr 28, 2021
@BillyONeal
Copy link
Member

BillyONeal commented Apr 28, 2021

Thanks for your contribution!

@JackBoosY JackBoosY deleted the dev/jack/fix_baseline_20210425 branch April 29, 2021 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JackBoosY @BillyONeal @PhoebeHui