[Openssl] Fix mingw build#17456
Conversation
|
Rebased on openssl 1.1.1j#2. |
|
Can we merge the security fix #16937 first? |
Sure. My PR is for a community triplet which simply doesn't build without a stack of patches. |
|
I cancelled the build because the infrastructure got wedged. I don't think it's a direct result of this PR |
|
There is also #17246. I wonder what is the best practice to coordinate PRs which target the same port. There is always a merge conflict. This is a unique problem in vcpkg, due to its versioning approach. Couldn't some automatism take over updating the port number and git tag? It is a mechanical task. |
|
I'm thinking of some GitHub actions that automatically updates the version files and merges after the PR is deemed ready to merge (could be with a command from the maintainers) |
|
When building Seems not related to your changes, right? |
|
No, this was in many CI runs, and probably subject of #17610. |
|
Yes that's unrelated, you can ignore it. |
|
Waiting for baseline PR. |
|
Waiting for #17628. |
|
@JackBoosY Now that #17628 is resolved, can we proceed with this? |
|
Thanks @dg0yt :) |
What does your PR fix?
Fixes a build error on mingw.
Which triplets are supported/not supported? Have you updated the CI baseline?
fixing mingw, -/-
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?yes