Skip to content

[Openssl] Fix mingw build#17456

Merged
strega-nil-ms merged 3 commits intomicrosoft:masterfrom
dg0yt:openssl-mingw
May 6, 2021
Merged

[Openssl] Fix mingw build#17456
strega-nil-ms merged 3 commits intomicrosoft:masterfrom
dg0yt:openssl-mingw

Conversation

@dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Apr 23, 2021

  • What does your PR fix?

    Fixes a build error on mingw.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    fixing mingw, -/-

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

@JackBoosY JackBoosY added the category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. label Apr 23, 2021
@dg0yt
Copy link
Contributor Author

dg0yt commented Apr 24, 2021

Rebased on openssl 1.1.1j#2.

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 25, 2021
@Hoikas
Copy link
Contributor

Hoikas commented Apr 29, 2021

Can we merge the security fix #16937 first?

@JackBoosY JackBoosY added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Apr 29, 2021
@dg0yt
Copy link
Contributor Author

dg0yt commented Apr 29, 2021

Can we merge the security fix #16937 first?

Sure. My PR is for a community triplet which simply doesn't build without a stack of patches.
I'm already subscribed to 16937 to see when it gets merged.

@dg0yt dg0yt marked this pull request as draft April 29, 2021 05:32
@BillyONeal
Copy link
Member

I cancelled the build because the infrastructure got wedged. I don't think it's a direct result of this PR

@dg0yt
Copy link
Contributor Author

dg0yt commented Apr 30, 2021

There is also #17246.

I wonder what is the best practice to coordinate PRs which target the same port. There is always a merge conflict. This is a unique problem in vcpkg, due to its versioning approach. Couldn't some automatism take over updating the port number and git tag? It is a mechanical task.

@longnguyen2004
Copy link
Contributor

I'm thinking of some GitHub actions that automatically updates the version files and merges after the PR is deemed ready to merge (could be with a command from the maintainers)

@dg0yt dg0yt force-pushed the openssl-mingw branch from 409a14c to e43e029 Compare May 1, 2021 14:11
@dg0yt dg0yt marked this pull request as ready for review May 2, 2021 04:03
@JackBoosY
Copy link
Contributor

When building hidapi:x64-osx:

autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force -I m4
configure.ac:16: error: AC_CONFIG_MACRO_DIR can only be used once
./lib/autoconf/general.m4:1970: AC_CONFIG_MACRO_DIR is expanded from...
configure.ac:16: the top level
autom4te: error: /usr/local/opt/m4/bin/m4 failed with exit status: 1
aclocal: error: /usr/local/Cellar/autoconf/2.71/bin/autom4te failed with exit status: 1
autoreconf: error: aclocal failed with exit status: 1

Seems not related to your changes, right?

@dg0yt
Copy link
Contributor Author

dg0yt commented May 2, 2021

No, this was in many CI runs, and probably subject of #17610.

@longnguyen2004
Copy link
Contributor

Yes that's unrelated, you can ignore it.

@JackBoosY JackBoosY added depends:different-pr This PR or Issue depends on a PR which has been filed and removed requires:author-response labels May 2, 2021
@JackBoosY
Copy link
Contributor

Waiting for baseline PR.

@JackBoosY
Copy link
Contributor

Waiting for #17628.

@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label May 2, 2021
@longnguyen2004
Copy link
Contributor

@JackBoosY Now that #17628 is resolved, can we proceed with this?

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 6, 2021
@strega-nil-ms
Copy link
Contributor

Thanks @dg0yt :)

@strega-nil-ms strega-nil-ms merged commit d66dae4 into microsoft:master May 6, 2021
@dg0yt dg0yt deleted the openssl-mingw branch May 7, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants