[cudnn] add other locations to find lib already installed#17346
[cudnn] add other locations to find lib already installed#17346strega-nil merged 6 commits intomicrosoft:masterfrom
Conversation
|
@rubenpraets @PBoog can you please tell me if this PR fixes your problem? It should, and it also fixes some problems I observed in some other linux configs |
|
I did a pull of your branch and yes, this solves my problem. Thanks! |
|
Works for me, thanks for the fix! |
| @@ -1,5 +1,6 @@ | |||
| Source: cudnn | |||
| Version: 7.6.5 | |||
There was a problem hiding this comment.
it really depends for me
on one side, the broader the compatibility the better (and so i’d push for even a lower version in the minimum accepted by the portfile)
on another hand, these port files which are not installing anything and just finding compatible versions on the systems are already breaking binary caches at least for me. Different configs produce the same hash due to the same portfile and become invalid when consumed on the wrong system. To fix this at least reducing acceptable versions is helpful
Describe the pull request
What does your PR fix?
Fixes [cudnn:x64-windows] build failure while installing opencv #17283
Without this PR, CUDNN cannot be found in some default linux folders when installed with apt-get. Also, moved all reasonable variables to ENV, since CMake has to look for them, otherwise they are unuseful
Which triplets are supported/not supported? Have you updated the CI baseline?
all
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes