[fontconfig] Don't require uuid port for mingw#17280
Merged
strega-nil-ms merged 2 commits intomicrosoft:masterfrom Apr 29, 2021
Merged
[fontconfig] Don't require uuid port for mingw#17280strega-nil-ms merged 2 commits intomicrosoft:masterfrom
strega-nil-ms merged 2 commits intomicrosoft:masterfrom
Conversation
JonLiu1993
added
the
category:port-bug
Contributor
JonLiu1993
added
the
info:needs-maintainer-attention
Contributor
|
It's so weird to me that mingw =/> windows... thanks for the PR @dg0yt :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
This PR fixes a failing dependency of fontconfig on mingw: The libuuid port is
linux|osx. On mingw as on a regular windows, there is a static uuid system library.Which triplets are supported/not supported? Have you updated the CI baseline?
mingw, -/-.
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
(There is another fontconfig mingw issue due to the pthread dependency but I would like to resolve this there.)