[grpc] Fix x86-windows build issue

[ykadowak]

• What does your PR fix?

  Fixes Grpc installed libraries difference between x64-windows and x86-windows #17247

• Does your PR follow the maintainer guide?

  Yes

I think this is a regression of b5bb151.
The original PR contains a lot of changes but I only understand a small part of it. So I am not sure if this is a right way to fix this.

[JonLiu1993]

@yusuke-kadowaki ,Thanks for your contribution,please run the vcpkg x-add-version grpc --overwrite-version command,then commit again

[JonLiu1993]

@yusuke-kadowaki ,please add "port-version" : 1 in the vcpkg.json

[JonLiu1993]

The failures caused by popsift will be fixed by #17277.

[ghost]

All CLA requirements met.

[ykadowak]

@yusuke-kadowaki ,please add "port-version" : 1 in the vcpkg.json

Wait, which vcpkg.json? I edited the grpc one from "port-version" : 3 to 1, which does not seem right.

[JonLiu1993]

@yusuke-kadowaki ,sorry!I made a mistake, I posted its comment on you when I was reviewing another pr, my fault

[ykadowak]

@JonLiu1993 Now I'm confused haha. I don't know why these tests are failing. Can you tell me what specifically you wanted me to do?

[dg0yt]

You changed the portfile, so you shall increment the port version. Than commit this change.
After this commit, let vcpkg register the new port version by vcpkg x-add-version grpc, and make another commit.
This is documented in the Versioning part of the mainainer's guide.

[ykadowak]

@dg0yt I was misunderstanding the versioning. Thank you for the comment.

[ras0219]

In order to avoid hard-coding so much about whether the target platform is executable, I've created an alternative PR #17424 which makes codegen a feature. You can then easily build it using vcpkg install grpc[codegen] or adding codegen to the list of required features in your manifest file.

@yusuke-kadowaki Could you try out that PR and let us know if it solves your issue?

[ykadowak]

@ras0219
I think desired behavior when running vcpkg install grpc on Windows is building with CODEGEN feature ON for both x64-windows and x86-windows. That is because building for x86-windows on x64-windows is not a usual cross compiling. It used to work like that before b5bb151.

Anyway, vcpkg install grpc[codegen] worked on my end too.

[ras0219]

The problem with that assumption is that arm64 is becoming much more prominent as a platform for all three OS's (Windows, OSX, and Linux). I think it's much better to have a consistent story that works for everyone, rather than trying to build a bunch of case-by-case stuff that is likely to need changes or be fully scrapped in the future.

[ykadowak]

I understand that the hard-coding part is bad and needs fixed anyway.

The only concern is, as I mentioned, it would be a bit confusing for x86-windows developer I think. What if you add something like this to you PR #17424.

else if((TARGET_TRIPLET STREQUAL "x86-windows") AND (HOST_TRIPLET STREQUAL "x64-windows"))
set(gRPC_BUILD_CODEGEN ON)

Just my opinion. I'm closing this and leave it to your PR.