[botan] update to version 2.17.3 by agrandville · Pull Request #17243 · microsoft/vcpkg

agrandville · 2021-04-12T21:52:15Z

feat add debug symbols

triplets supported/not supported? Have you updated the CI baseline?

all
Does your PR follow the maintainer guide?

YES
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

YES

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

feat add debug symbols

autoantwort · 2021-04-12T23:07:21Z

Please run ./vcpkg format-manifest --all :)

NancyLi1013

Could you please update botan as ${PORT} in the following codes?

vcpkg_copy_tool_dependencies(${CURRENT_PACKAGES_DIR}/tools/botan)
file(RENAME ${CURRENT_PACKAGES_DIR}/share/botan-${BOTAN_VERSION}/ ${CURRENT_PACKAGES_DIR}/share/botan/)
file(RENAME ${CURRENT_PACKAGES_DIR}/share/botan/license.txt ${CURRENT_PACKAGES_DIR}/share/botan/copyright)

ports/botan/portfile.cmake

ports/botan/vcpkg.json

versions/b-/botan.json

NancyLi1013 · 2021-04-13T02:14:04Z

Please run./vcpkg format-manifest ./ports/botan/vcpkg.json to format vcpkg.json file.

vcpkg format-manifest --all

versions/b-/botan.json

NancyLi1013 · 2021-04-13T08:56:40Z

LGTM now, thanks for your update @agrandville.

For the failures on osx pipeline, there is something wrong with our CI, which is not related with this PR. I will rerun it once solved.

NancyLi1013 · 2021-04-14T02:30:30Z

/azp run

azure-pipelines · 2021-04-14T02:30:38Z

Azure Pipelines successfully started running 1 pipeline(s).

NancyLi1013 · 2021-04-14T05:53:53Z

The failures caused by popsift will be fixed by #17277.

add copyright file

NancyLi1013 · 2021-04-15T01:54:51Z

Error: While reading versions for port botan from file: C:\a\1\s\versions\b-\botan.json
       File declares version `2.17.3` with SHA: f355b4fc82c9cb1c7de67be66ac517931a488f01
       But local port with the same verion has a different SHA: 2d15c43909a9409da601e7b01a9a3a288c50bfb9
       Please update the port's version fields and then run:

           vcpkg x-add-version botan

       to add a new version.

Please run vcpkg x-add-version botan again to update versions.

Note: Have you tested the usage of botan? I noticed that added botanConfig.cmake file in the last commit.

agrandville · 2021-04-15T11:18:16Z

I'm upgrading the cmake scripts of opendnssec/SoftHSMv2 project who use vcpkg botan.
For now, SoftHSM compile, with botan crypto backend and vcpkg toolchain, fails due to missing BotanConfig.cmake file.

update port-version to 1

versions/b-/botan.json

ports/botan/vcpkg.json

NancyLi1013 · 2021-04-16T02:34:42Z

You can use vcpkg-x-add-version --overwrite-version botan to update the version files.

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

versions/baseline.json

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

strega-nil-ms · 2021-04-29T23:29:19Z

@agrandville could you please merge with latest?

# Conflicts: # ports/botan/vcpkg.json # versions/b-/botan.json # versions/baseline.json

strega-nil-ms · 2021-05-26T21:09:03Z

ports/botan/CMakeLists.txt

@@ -0,0 +1,51 @@
+project(botan)


Why is this file here? it doesn't seem to be used by portfile.cmake...

Thanks for pointing this out @strega-nil-ms. Sorry, I missed this point before.

NancyLi1013 · 2021-07-20T07:39:58Z

@agrandville

Could you please address the review suggestions? Thanks.

PhoebeHui · 2021-09-14T05:42:53Z

Closing this PR since it seems that no progress is being made. Please reopen if work is still being done.
botan has been updated to 2.18.1.

[botan] update to version 2.17.3

7d64c41

feat add debug symbols

NancyLi1013 self-assigned this Apr 13, 2021

NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 13, 2021

NancyLi1013 suggested changes Apr 13, 2021

View reviewed changes

ports/botan/portfile.cmake Outdated Show resolved Hide resolved

ports/botan/portfile.cmake Show resolved Hide resolved

ports/botan/vcpkg.json Outdated Show resolved Hide resolved

versions/b-/botan.json Outdated Show resolved Hide resolved

NancyLi1013 added the requires:author-response label Apr 13, 2021

agrandville added 3 commits April 13, 2021 07:42

manifest reformated

58be1a2

vcpkg format-manifest --all

fix PR #17243

7de4143

fix PR #17243

f7ba31a

agrandville marked this pull request as draft April 13, 2021 07:32

agrandville marked this pull request as ready for review April 13, 2021 07:44

NancyLi1013 suggested changes Apr 13, 2021

View reviewed changes

versions/b-/botan.json Outdated Show resolved Hide resolved

Merge branch 'master' of https://github.com/agrandville/vcpkg into HEAD

b8c15dc

NancyLi1013 approved these changes Apr 13, 2021

View reviewed changes

NancyLi1013 removed the requires:author-response label Apr 13, 2021

feat add package configuration file

9bf3e81

add copyright file

NancyLi1013 added the requires:author-response label Apr 15, 2021

fix update checksum

5f76183

update port-version to 1

NancyLi1013 suggested changes Apr 16, 2021

View reviewed changes

versions/b-/botan.json Show resolved Hide resolved

versions/b-/botan.json Outdated Show resolved Hide resolved

ports/botan/vcpkg.json Outdated Show resolved Hide resolved

agrandville and others added 3 commits April 16, 2021 09:02

Update versions/b-/botan.json

bac1042

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

Update ports/botan/vcpkg.json

ebe4d9b

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

Update versions/b-/botan.json

47d01b1

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

NancyLi1013 suggested changes Apr 16, 2021

View reviewed changes

versions/baseline.json Outdated Show resolved Hide resolved

agrandville and others added 4 commits April 16, 2021 09:08

Update versions/baseline.json

e58de8f

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

fix update checksum

9085fcc

fix remove port-version

d56b11a

fix update version checksum

b7b66f5

NancyLi1013 approved these changes Apr 16, 2021

View reviewed changes

NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Apr 16, 2021

strega-nil-ms added the requires:author-response label Apr 29, 2021

BillyONeal removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 7, 2021

agrandville and others added 3 commits May 13, 2021 18:33

feat add CMakeLists.txt

dec0c24

Merge branch 'master' of https://github.com/Microsoft/vcpkg

395eca6

# Conflicts: # ports/botan/vcpkg.json # versions/b-/botan.json # versions/baseline.json

Update versions/b-/botan.json

9550ad4

NancyLi1013 removed the requires:author-response label May 20, 2021

NancyLi1013 approved these changes May 20, 2021

View reviewed changes

NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 20, 2021

strega-nil-ms suggested changes May 26, 2021

View reviewed changes

strega-nil-ms added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels May 26, 2021

PhoebeHui mentioned this pull request Sep 2, 2021

[botan] update to 2.18.1 #19906

Closed

PhoebeHui closed this Sep 14, 2021

Conversation

agrandville commented Apr 12, 2021

triplets supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Uh oh!

autoantwort commented Apr 12, 2021

Uh oh!

NancyLi1013 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NancyLi1013 commented Apr 13, 2021

Uh oh!

Uh oh!

NancyLi1013 commented Apr 13, 2021

Uh oh!

NancyLi1013 commented Apr 14, 2021

Uh oh!

azure-pipelines bot commented Apr 14, 2021

Uh oh!

NancyLi1013 commented Apr 14, 2021

Uh oh!

NancyLi1013 commented Apr 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agrandville commented Apr 15, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NancyLi1013 commented Apr 16, 2021

Uh oh!

Uh oh!

strega-nil-ms commented Apr 29, 2021

Uh oh!

strega-nil-ms May 26, 2021

Choose a reason for hiding this comment

Uh oh!

NancyLi1013 May 27, 2021

Choose a reason for hiding this comment

Uh oh!

NancyLi1013 commented Jul 20, 2021

Uh oh!

PhoebeHui commented Sep 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

NancyLi1013 commented Apr 15, 2021 •

edited

Loading

PhoebeHui commented Sep 14, 2021 •

edited

Loading