Skip to content

[hidapi] Add support linux and osx#17231

Merged
strega-nil-ms merged 4 commits intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/support-linux-and-osx-for-hidapi
Apr 30, 2021
Merged

[hidapi] Add support linux and osx#17231
strega-nil-ms merged 4 commits intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/support-linux-and-osx-for-hidapi

Conversation

@NancyLi1013
Copy link
Contributor

@NancyLi1013 NancyLi1013 commented Apr 12, 2021

Describe the pull request

Note: No feature needs to test.

@NancyLi1013 NancyLi1013 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal labels Apr 12, 2021
@NancyLi1013
Copy link
Contributor Author

NancyLi1013 commented Apr 12, 2021

The failures on osx pipeline:

autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force -I m4
configure.ac:16: error: AC_CONFIG_MACRO_DIR can only be used once
./lib/autoconf/general.m4:1970: AC_CONFIG_MACRO_DIR is expanded from...
configure.ac:16: the top level
autom4te: error: /usr/local/opt/m4/bin/m4 failed with exit status: 1
aclocal: error: /usr/local/Cellar/autoconf/2.71/bin/autom4te failed with exit status: 1
autoreconf: error: aclocal failed with exit status: 1

@NancyLi1013 NancyLi1013 marked this pull request as ready for review April 13, 2021 09:41
@NancyLi1013 NancyLi1013 requested a review from JackBoosY April 13, 2021 09:41
@NancyLi1013
Copy link
Contributor Author

NancyLi1013 commented Apr 14, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 14, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

JackBoosY commented Apr 14, 2021 •
edited
Loading 

CMake Error at ports/popsift/portfile.cmake:9 (include):
  include could not find load file:

    D:/installed/x64-windows/share/vcpkg_find_cuda/vcpkg_find_cuda.cmake
Call Stack (most recent call first):
  scripts/ports.cmake:142 (include)

Is this related to your changes?
Depends on #17277

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Apr 14, 2021
@NancyLi1013
Copy link
Contributor Author

NancyLi1013 commented Apr 15, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 15, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Apr 15, 2021
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 15, 2021
@strega-nil-ms
Copy link
Contributor

strega-nil-ms commented Apr 30, 2021

Thanks Nancy :)

@strega-nil-ms strega-nil-ms merged commit efddfbf into microsoft:master Apr 30, 2021
@autoantwort
Copy link
Contributor

autoantwort commented May 1, 2021

The failures on osx pipeline:

autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force -I m4
configure.ac:16: error: AC_CONFIG_MACRO_DIR can only be used once
./lib/autoconf/general.m4:1970: AC_CONFIG_MACRO_DIR is expanded from...
configure.ac:16: the top level
autom4te: error: /usr/local/opt/m4/bin/m4 failed with exit status: 1
aclocal: error: /usr/local/Cellar/autoconf/2.71/bin/autom4te failed with exit status: 1
autoreconf: error: aclocal failed with exit status: 1

I am now getting the same error in the pipeline of my PRs for this port?

@autoantwort autoantwort mentioned this pull request May 1, 2021
Closed
autoantwort
autoantwort reviewed May 1, 2021
View reviewed changes
@autoantwort autoantwort mentioned this pull request May 1, 2021
Merged
@JackBoosY JackBoosY mentioned this pull request May 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@autoantwort autoantwort autoantwort left review comments

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[hidapi] Support for x64-linux [hidapi] Linux/macOS support

4 participants

@NancyLi1013 @JackBoosY @strega-nil-ms @autoantwort