[triton] Add new port#17224
[triton] Add new port#17224illera88 wants to merge 2 commits intomicrosoft:masterfrom illera88:master
Conversation
NancyLi1013
added
the
category:new-port
| Version: dev-v0.9 | ||
| Homepage: https://github.com/JonathanSalwan/Triton | ||
| Description: Triton is a Dynamic Binary Analysis (DBA) framework. It provides internal components like a Dynamic Symbolic Execution (DSE) engine, a dynamic taint engine, AST representations of the x86, x86-64, ARM32 and AArch64 Instructions Set Architecture (ISA), SMT simplification passes, an SMT solver interface and, the last but not least, Python bindings. | ||
| Build-Depends: z3, capstone, boost-multiprecision, boost-numeric-conversion, boost-math |
There was a problem hiding this comment.
Can you use vcpkg.json instead of CONTROL?
Please see the reference https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/pr-review-checklist.md
| @@ -0,0 +1,5 @@ | |||
| Source: triton | |||
| Version: dev-v0.9 | |||
There was a problem hiding this comment.
Seems like the version uses a unstable one. I noticed that there are also released versions. Why do you not use the latest release here?
Also, please follow the new policy to rename this field in vcpkg.json.
https://github.com/microsoft/vcpkg/blob/master/docs/users/versioning.md
https://github.com/microsoft/vcpkg/blob/master/docs/users/versioning.reference.md
| set(Z3_LIBRARY ${VCPKG_ROOT_DIR}/installed/${TARGET_TRIPLET}/lib/libz3${VCPKG_TARGET_STATIC_LIBRARY_SUFFIX}) | ||
|
|
||
|
|
||
| vcpkg_configure_cmake( |
There was a problem hiding this comment.
We also prefer to use the new functions in a new port. Since the current functions have deprecated. Please see
https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/vcpkg_configure_cmake.md
Other functions like vcpkg_install_cmake() also needs to be updated.
If we use new functions, vcpkg-cmake is required to be added as a dependency like this:
{
"name": "vcpkg-cmake",
"host": true
}
| vcpkg_install_cmake() | ||
| vcpkg_copy_pdbs() | ||
|
|
||
| configure_file("${CURRENT_BUILDTREES_DIR}/src/dev-v0.9-fd0ccd4864.clean/LICENSE.txt" "${CURRENT_PACKAGES_DIR}/share/triton/copyright" COPYONLY) |
There was a problem hiding this comment.
| configure_file("${CURRENT_BUILDTREES_DIR}/src/dev-v0.9-fd0ccd4864.clean/LICENSE.txt" "${CURRENT_PACKAGES_DIR}/share/triton/copyright" COPYONLY) | |
| configure_file("${CURRENT_BUILDTREES_DIR}/src/dev-v0.9-fd0ccd4864.clean/LICENSE.txt" "${CURRENT_PACKAGES_DIR}/share/${PORT}/copyright" COPYONLY) |
|
Hi @illera88 |
|
Is work still being done for this PR? |
|
Thanks for the PR; we're closing this for now since there's been no response. If you'd like to continue working on it, please reopen and ping us! |
2 participants
This PR adds support for Triton
Related: #10942