[libtorrent] Update to latest 1.2.x commit #17166
Merged
strega-nil-ms merged 2 commits intomicrosoft:masterfrom Apr 30, 2021
Merged
[libtorrent] Update to latest 1.2.x commit #17166strega-nil-ms merged 2 commits intomicrosoft:masterfrom
strega-nil-ms merged 2 commits intomicrosoft:masterfrom
Conversation
JonLiu1993
added
the
category:port-update
- Update to 1.2.13 plus some additional fixes (allows dropping existing patches) - Build with libiconv by default on all platforms - Fix deprecated usage of `vcpkg_check_features` without the `FEATURES` keyword - Migrate to vcpkg.json manifest files
FranciscoPombal
force-pushed
the
update_libtorrent
branch
from
33b49a2 to
6169ac5
Compare
JonLiu1993
reviewed
Apr 9, 2021
JonLiu1993
reviewed
Apr 9, 2021
Contributor
|
@FranciscoPombal ，Thanks for your contribute |
FranciscoPombal
force-pushed
the
update_libtorrent
branch
from
6169ac5 to
bb587c7
Compare
Contributor
Author
|
@JonLiu1993 Looks like we have to use "version-string": So I've reverted the fixes made in response to your review comments. |
FranciscoPombal
force-pushed
the
update_libtorrent
branch
from
bb587c7 to
6169ac5
Compare
JonLiu1993
added
info:needs-maintainer-attention
JonLiu1993
approved these changes
Apr 12, 2021
Contributor
Author
|
@JonLiu1993 Anything preventing this from being merged? |
Contributor
|
@FranciscoPombal ,Don’t worry, soon this pr will be merged with other prs. |
Contributor
|
Thanks @FranciscoPombal :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patches)
vcpkg_check_featureswithout theFEATURESkeyword
[libtorrent] Update versioning information
Previously: #15620 and #14755.
1.2.14 may take a while to come, and this is a good opportunity to get rid of all patches and migrate to manifest files. Hopefully this will make future work of getting the python feature to work on Windows easier.
Tested on
x64-linux,x64-windows, andx64-windows-static.