Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lua 5.1] Added old version of lua #17135

Closed
wants to merge 4 commits into from
Closed

[Lua 5.1] Added old version of lua #17135

wants to merge 4 commits into from

Conversation

mathisloge
Copy link
Contributor

Describe the pull request

So I don't really know if this is the correct way of adding a older version of a already newer library. But i thought i will give it a try.

@mathisloge
Copy link
Contributor Author

pinging @vadi2 as he requested this and might have time to test this as soon as it is ready to use.

@mathisloge
Copy link
Contributor Author

waiting for the ci run and then pushing the commits to go back to version 5.4.3

@vadi2
Copy link
Contributor

vadi2 commented Apr 7, 2021

Nice, how would I try this in the project?

@mathisloge
Copy link
Contributor Author

Nice, how would I try this in the project?

currently you could clone the https://github.com/mathisloge/vcpkg with the branch lua 5.1.
But after i push the commits to go back to 5.4.3 you need to follow https://github.com/microsoft/vcpkg/blob/master/docs/users/versioning.md to freeze the version to 5.1

@vicroms
Copy link
Member

vicroms commented Apr 7, 2021

Per policy we don't allow downgrading of libraries. The correct way to accomplish this would be to create your own custom Git registry and push the needed versions to that registry.

You can read our registries blog post that includes an in-depth tutorial. If you need more help setting this up for your project/team please feel free to open a new discussion or contact us by email or Slack/Discord.

@mathisloge
Copy link
Contributor Author

mathisloge commented Apr 7, 2021

So I thought if I'm pushing it back to 5.4.3 the version feature should allow projects to consume the 5.1 version. But since lua started (in vcpkg) with version 5.4.3 only versions beginning with this version are supported in the future?

All older versions have to live in a custom registry?

Thanks for clarifying.

@vicroms
Copy link
Member

vicroms commented Apr 7, 2021

@mathisloge

That's correct. Our current stance is to have missing versions be provided by custom registries; we hope that a federated environment of high-quality custom registries is born at some point in time that can address the shortcomings of the main registry. We also may change our stance on this in the future.

@mathisloge mathisloge closed this Apr 7, 2021
@mathisloge
Copy link
Contributor Author

@vadi2 Have created a custom registry as @vicroms said with lua versions 5.1, 5.2 and 5.3 since 5.4 and onward will be supported from vcpkg main repo
https://github.com/mathisloge/vcpkg-registry

@mathisloge
Copy link
Contributor Author

@vicroms should maybe also close #7713

@mathisloge mathisloge deleted the lua51 branch April 8, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lua] 5.1 version
3 participants