Skip to content

[libmariadb] Fix build error with cmake 3.20.0#17113

Merged
vicroms merged 4 commits intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/fix-libmariadb
Apr 7, 2021
Merged

[libmariadb] Fix build error with cmake 3.20.0#17113
vicroms merged 4 commits intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/fix-libmariadb

Conversation

@NancyLi1013
Copy link
Contributor

@NancyLi1013 NancyLi1013 commented Apr 6, 2021

Describe the pull request

Build error in cmake 3.20.0 with the following errors:

CMake Error at cmake/ConnectorName.cmake:30 (ENDMACRO):
  Flow control statements are not properly nested.
Call Stack (most recent call first):
  CMakeLists.txt:424 (INCLUDE)

The fix from upstream mariadb-corporation/mariadb-connector-c@242cab8c

Note: No need to test features.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Apr 6, 2021
JackBoosY
JackBoosY suggested changes Apr 6, 2021
View reviewed changes
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 7, 2021
@vicroms vicroms merged commit 88e0310 into microsoft:master Apr 7, 2021
@glennpj glennpj mentioned this pull request Apr 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[libmariadb] build failure with cmake 3.20.0

3 participants

@NancyLi1013 @JackBoosY @vicroms