[sdl2] Fix pthread detection on macOS#17106
Merged
vicroms merged 4 commits intomicrosoft:masterfrom Apr 7, 2021
Merged
Conversation
NancyLi1013
added
the
category:port-bug
NancyLi1013
approved these changes
Apr 6, 2021
NancyLi1013
added
the
info:needs-maintainer-attention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes cross-compiling the
sdl2port on macOS.Specifically, in a common CI scenario, an x64 build machine is used to build an arm64 version of the port. Previously, this would fail to properly detect the availability of pthreads, and would result in an arm64 build of
sdl2that was (quietly) missing support for SDL's "Threads" subsystem. (Which would likely only be discovered when attempting to run a dependent program on arm64 macOS, which would then fail out.)Also includes a small drive-by fix for a deprecation warning re:
vcpkg_check_features.