Skip to content

Update libjuice to 0.7.1 to update libdatachannel#17076

Merged
vicroms merged 5 commits intomicrosoft:masterfrom
Nemirtingas:libjuice_update
Apr 7, 2021
Merged

Update libjuice to 0.7.1 to update libdatachannel#17076
vicroms merged 5 commits intomicrosoft:masterfrom
Nemirtingas:libjuice_update

Conversation

@Nemirtingas
Copy link
Contributor

@Nemirtingas Nemirtingas commented Apr 4, 2021

Describe the pull request
Updates libjuice to 0.7.1 to update libdatachannel to 0.12.0.

@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label Apr 5, 2021
@@ -0,0 +1,14 @@
{
"name": "libjuice",
"version-string": "v0.7.1",
Copy link
Contributor

@JonLiu1993 JonLiu1993 Apr 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nemirtingas ,Because its version is a progressive combination of consecutive numbers, we should use "version" instead of "version-string", Please do not include ‘v’ in the version.

"versions": [
{
"git-tree": "f3e297509756bb3afa9577b985f33c26f6867f29",
"version-string": "v0.7.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use "version" instead of "version-string"

@Nemirtingas
Copy link
Contributor Author

Hi thanks, should I put something like:
"version": "0.7.1" or "version-semver": "0.7.1" ?

#17077 (comment)

I'm quite lost, version formats everywhere.

@JonLiu1993
Copy link
Contributor

JonLiu1993 commented Apr 7, 2021

Hi thanks, should I put something like:
"version": "0.7.1" or "version-semver": "0.7.1" ?

#17077 (comment)

I'm quite lost, version formats everywhere.

Here we should use "version", if you are confused about this, you can refer to the detailed meaning and difference here

@Nemirtingas
Copy link
Contributor Author

Hi thanks, should I put something like:
"version": "0.7.1" or "version-semver": "0.7.1" ?
#17077 (comment)
I'm quite lost, version formats everywhere.

Here you should use "version", if you are confused about this, you can refer to the detailed meaning and difference here

Ok then, but why does NancyLi1013 want to use version-semver while we have the same version scheme ? e.g. X.Y.Z ?

@JonLiu1993
Copy link
Contributor

Hi thanks, should I put something like:
"version": "0.7.1" or "version-semver": "0.7.1" ?
#17077 (comment)
I'm quite lost, version formats everywhere.

Here you should use "version", if you are confused about this, you can refer to the detailed meaning and difference here

Ok then, but why does NancyLi1013 want to use version-semver while we have the same version scheme ? e.g. X.Y.Z ?

Generally speaking, if every number of the version has meaning or there is an api change in the version update, you need to use version-semver. If the number of the version has no meaning, it is incremental or there is no API change, you need to use version, if it is generally a date. Need to use version-date

@JonLiu1993 JonLiu1993 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Apr 7, 2021
@Nemirtingas
Copy link
Contributor Author

Generally speaking, if every number of the version has meaning or there is an api change in the version update, you need to use version-semver. If the number of the version has no meaning, it is incremental or there is no API change, you need to use version, if it is generally a date. Need to use version-date

Thanks for the explanation, I'll keep this in mind.

@vicroms vicroms merged commit 12eb540 into microsoft:master Apr 7, 2021
@Nemirtingas Nemirtingas deleted the libjuice_update branch April 9, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants