Update libjuice to 0.7.1 to update libdatachannel#17076
Update libjuice to 0.7.1 to update libdatachannel#17076vicroms merged 5 commits intomicrosoft:masterfrom
Conversation
ports/libjuice/vcpkg.json
Outdated
| @@ -0,0 +1,14 @@ | |||
| { | |||
| "name": "libjuice", | |||
| "version-string": "v0.7.1", | |||
There was a problem hiding this comment.
@Nemirtingas ,Because its version is a progressive combination of consecutive numbers, we should use "version" instead of "version-string", Please do not include ‘v’ in the version.
versions/l-/libjuice.json
Outdated
| "versions": [ | ||
| { | ||
| "git-tree": "f3e297509756bb3afa9577b985f33c26f6867f29", | ||
| "version-string": "v0.7.1", |
There was a problem hiding this comment.
we should use "version" instead of "version-string"
|
Hi thanks, should I put something like: I'm quite lost, version formats everywhere. |
Here we should use "version", if you are confused about this, you can refer to the detailed meaning and difference here |
Ok then, but why does NancyLi1013 want to use version-semver while we have the same version scheme ? e.g. X.Y.Z ? |
Generally speaking, if every number of the version has meaning or there is an api change in the version update, you need to use version-semver. If the number of the version has no meaning, it is incremental or there is no API change, you need to use version, if it is generally a date. Need to use version-date |
Thanks for the explanation, I'll keep this in mind. |
Describe the pull request
Updates libjuice to 0.7.1 to update libdatachannel to 0.12.0.