Skip to content

[libwebsockets] Fix usage, export include path#17003

Merged
vicroms merged 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/16466
Apr 7, 2021
Merged

[libwebsockets] Fix usage, export include path#17003
vicroms merged 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/16466

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

Both the marco LIBWEBSOCKETS_INCLUDE_DIR and the INTERFACE_INLUCDE_DIR is empty:

CMake Error in CMakeLists.txt:
  Found relative path while evaluating include directories of "ZERO_CHECK":

    "LIBWEBSOCKETS_INCLUDE_DIR-NOTFOUND
set_target_properties(websockets_shared PROPERTIES
  INTERFACE_LINK_LIBRARIES "${_IMPORT_PREFIX}/lib/libssl.lib;${_IMPORT_PREFIX}/lib/libcrypto.lib;\$<\$<NOT:\$<CONFIG:DEBUG>>:${_IMPORT_PREFIX}/lib/pthreadVC3.lib>;\$<\$<CONFIG:DEBUG>:${_IMPORT_PREFIX}/debug/lib/pthreadVC3d.lib>;\$<\$<NOT:\$<CONFIG:DEBUG>>:${_IMPORT_PREFIX}/lib/pthreadVC3.lib>;\$<\$<CONFIG:DEBUG>:${_IMPORT_PREFIX}/debug/lib/pthreadVC3d.lib>;ws2_32.lib;userenv.lib;psapi.lib;iphlpapi.lib;crypt32.lib;\$<\$<NOT:\$<CONFIG:DEBUG>>:${_IMPORT_PREFIX}/lib/zlib.lib>;\$<\$<CONFIG:DEBUG>:${_IMPORT_PREFIX}/debug/lib/zlibd.lib>;${_IMPORT_PREFIX}/lib/libuv.lib"
)

Fix this.

Fixes #16466.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Apr 1, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor Author

@kzhdev Can you please test this PR?

Thanks.

@JackBoosY
Copy link
Copy Markdown
Contributor Author

Depend on #17011.

@JackBoosY JackBoosY added depends:different-pr This PR or Issue depends on a PR which has been filed and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Apr 1, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY requested a review from NancyLi1013 April 3, 2021 14:18
@kzhdev
Copy link
Copy Markdown
Contributor

kzhdev commented Apr 4, 2021

@JackBoosY Verified the issue is fixed. Thanks.

@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 7, 2021
@vicroms vicroms merged commit ff615bb into microsoft:master Apr 7, 2021
@JackBoosY JackBoosY deleted the dev/jack/16466 branch April 8, 2021 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

find_path not working on Windows

4 participants