[libfido2] New port by xgcssch · Pull Request #16965 · microsoft/vcpkg

xgcssch · 2021-03-30T12:45:13Z

This PR introduces libfido2 as a new port

What does your PR fix?
-/-
Which triplets are supported/not supported?
*-windows
Have you updated the CI baseline?
no
Does your PR follow the maintainer guide?
yes

ports/libfido2/portfile.cmake

ports/libfido2/vcpkg.json

ports/libfido2/find_packages.patch

NancyLi1013 · 2021-03-31T02:38:20Z

Hi @xgcssch

Thanks for your PR.

I also noticed that there was a new released version 1.7.0. So would you like to update it to the latest release in this PR?

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

ports/libfido2/vcpkg.json

versions/l-/libfido2.json

NancyLi1013 · 2021-03-31T08:24:59Z

Could you please also address the review suggestions?

xgcssch · 2021-03-31T08:30:20Z

Hello Nancy!
Sorry for the checkin with only the 1.7 update.
I haven't recognized the suggestions you made.
I am currently working on them.
Thanks

NancyLi1013 · 2021-03-31T10:23:04Z

The failures on x86-windows and x64-windows:

/MANIFESTFILE:src\CMakeFiles\fido2_shared.dir/intermediate.manifest src\CMakeFiles\fido2_shared.dir/manifest.res" failed (exit code 1120) with the following output:
   Creating library src\fido2.lib and object src\fido2.exp
compress.c.obj : error LNK2019: unresolved external symbol compress referenced in function do_compress
compress.c.obj : error LNK2019: unresolved external symbol compressBound referenced in function do_compress
compress.c.obj : error LNK2019: unresolved external symbol uncompress referenced in function do_compress
src\fido2.dll : fatal error LNK1120: 3 unresolved externals
ninja: build stopped: subcommand failed.

ports/libfido2/portfile.cmake

ports/libfido2/vcpkg.json

NancyLi1013 · 2021-04-14T10:13:33Z

The failures cause by popsift will be fixed by #17277.

NancyLi1013 · 2021-04-15T01:50:17Z

/azp run

azure-pipelines · 2021-04-15T01:50:25Z

Azure Pipelines successfully started running 1 pipeline(s).

NancyLi1013 · 2021-04-15T01:56:42Z

LGTM now, thanks for adding this port @xgcssch.

strega-nil-ms · 2021-04-30T18:34:27Z

@xgcssch could you rebase on latest? thanks!

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

xgcssch · 2021-05-01T12:19:38Z

Done!

BillyONeal · 2021-05-07T00:41:24Z

Thanks for your contribution!

xgcssch added 6 commits March 30, 2021 14:39

[libfido2] New port

9654a8c

[libfido2] Update versions

aee4aa3

[libfido2] Fixed invalid dll rename in static library versions

a2b0586

[libfido2] Update versions

30f26d3

[libfido2] Exclude UWP from supported platforms

9bd3ec2

[libfido2] Update versions

6f4db5b

NancyLi1013 self-assigned this Mar 31, 2021

NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 31, 2021

NancyLi1013 suggested changes Mar 31, 2021

View reviewed changes

NancyLi1013 added the requires:author-response label Mar 31, 2021

xgcssch and others added 3 commits March 31, 2021 09:56

[libfido2] Bump version to new upstream 1.7 release

d3efc1f

[libfido2] Update versions

6f8c278

Fix indenting

bb92335

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

NancyLi1013 suggested changes Mar 31, 2021

View reviewed changes

ports/libfido2/vcpkg.json Outdated Show resolved Hide resolved

versions/l-/libfido2.json Outdated Show resolved Hide resolved

versions/l-/libfido2.json Outdated Show resolved Hide resolved

xgcssch added 2 commits March 31, 2021 13:59

[libfido2] Implement multiple issues/suggestions from PR

9f8cfe4

[libfido2] Update versions

82225fb

NancyLi1013 suggested changes Apr 1, 2021

View reviewed changes

ports/libfido2/portfile.cmake Outdated Show resolved Hide resolved

xgcssch added 2 commits April 1, 2021 12:43

[libfido2] Removed surplus option from vcpkg_from_github

5e0ccd0

[libfido2] Update versions

be02f6d

xgcssch requested a review from NancyLi1013 April 12, 2021 15:08

NancyLi1013 reviewed Apr 13, 2021

View reviewed changes

ports/libfido2/portfile.cmake Outdated Show resolved Hide resolved

NancyLi1013 reviewed Apr 13, 2021

View reviewed changes

ports/libfido2/portfile.cmake Outdated Show resolved Hide resolved

NancyLi1013 suggested changes Apr 13, 2021

View reviewed changes

ports/libfido2/vcpkg.json Show resolved Hide resolved

xgcssch added 3 commits April 13, 2021 18:01

[libfido2] Apply suggested changes to use the new vcpkg-cmake port

8d6bff6

[libfido2] Update versions

0d0a91e

[libfido2] Reapply formatting

a380804

NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 15, 2021

xgcssch and others added 20 commits May 1, 2021 13:17

[libfido2] New port

0467e28

[libfido2] Update versions

9ac8b2d

[libfido2] Fixed invalid dll rename in static library versions

a0a2eaa

[libfido2] Update versions

3dd0bc8

[libfido2] Exclude UWP from supported platforms

38bcef0

[libfido2] Update versions

915bbe1

[libfido2] Bump version to new upstream 1.7 release

954a4f8

[libfido2] Update versions

d4813db

Fix indenting

51dbcfb

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

[libfido2] Implement multiple issues/suggestions from PR

95231b7

[libfido2] Update versions

a362d9a

[libfido2] Removed surplus option from vcpkg_from_github

08d2ff3

[libfido2] Update versions

c18fcff

[libfido2] Apply suggested changes to use the new vcpkg-cmake port

3cc6885

[libfido2] Update versions

7ca2836

[libfido2] Reapply formatting

3a7e6ab

[libfido2] Update versions

dfc029d

[libfido2] Changed dependency entry for vcpkg-cmake

2601147

[libfido2] Update versions

2d2b93f

Rebase to head

ae3a0b6

Merge remote-tracking branch 'upstream/master' into libfido2

7a93e3f

BillyONeal merged commit 09ff624 into microsoft:master May 7, 2021

Conversation

xgcssch commented Mar 30, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NancyLi1013 commented Mar 31, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NancyLi1013 commented Mar 31, 2021

Uh oh!

xgcssch commented Mar 31, 2021

Uh oh!

NancyLi1013 commented Mar 31, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NancyLi1013 commented Apr 14, 2021

Uh oh!

NancyLi1013 commented Apr 15, 2021

Uh oh!

azure-pipelines bot commented Apr 15, 2021

Uh oh!

NancyLi1013 commented Apr 15, 2021

Uh oh!

strega-nil-ms commented Apr 30, 2021

Uh oh!

xgcssch commented May 1, 2021

Uh oh!

BillyONeal commented May 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants