Skip to content

[vcpkg] Convert env vars slash if host is Win32#16927

Merged
vicroms merged 1 commit intomicrosoft:masterfrom
huangqinjin:fix-env-vars
Apr 7, 2021
Merged

[vcpkg] Convert env vars slash if host is Win32#16927
vicroms merged 1 commit intomicrosoft:masterfrom
huangqinjin:fix-env-vars

Conversation

@huangqinjin
Copy link
Contributor

Environment variables are host properties rather than target.

Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@PhoebeHui PhoebeHui self-assigned this Mar 29, 2021
@PhoebeHui PhoebeHui added category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Mar 29, 2021
@vicroms vicroms merged commit 2e35636 into microsoft:master Apr 7, 2021
@huangqinjin huangqinjin deleted the fix-env-vars branch April 11, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants