Merged
Conversation
This was referenced Mar 27, 2021
PhoebeHui
added
the
category:port-update
PhoebeHui
requested changes
Mar 27, 2021
Contributor
PhoebeHui
left a comment
PhoebeHui
left a comment
There was a problem hiding this comment.
Thanks for the PR! Could you update the baseline revision by executing "./vcpkg x-add-version nowide"? And submit the changes.
Please ignore the CI failures, I will rerun this PR after the baseline issue fixed.
Contributor
Author
|
@PhoebeHui Done. |
PhoebeHui
approved these changes
Mar 29, 2021
Contributor
PhoebeHui
left a comment
PhoebeHui
left a comment
There was a problem hiding this comment.
LGTM, thanks for the updates!
PhoebeHui
added
the
info:needs-maintainer-attention
Contributor
|
nowide 11.1.1 is not available any more. That causes pipeline failures, I have created #17209 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix? Fixes [nowide] update to 11.1.1 #16912
Which triplets are supported/not supported? Have you updated the CI baseline?
Same as the current version
Does your PR follow the maintainer guide?
Probably yes