[mpg123] Upgrade to 1.26.3-1#16910
Merged
ras0219-msft merged 2 commits intomicrosoft:masterfrom Apr 2, 2021
Merged
Conversation
This was referenced Mar 27, 2021
PhoebeHui
added
the
category:port-bug
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 16910 in repo microsoft/vcpkg |
Fix invalid MPG123_API_VERSION value in mpg123.h.in for Windows platform. It was equal to @API_VERSION@, now it is read from configure.ac and set to correct value. See also libsndfile/libsndfile#499.
Contributor
Author
|
@PhoebeHui , can you restart checks? |
evpobr
added a commit
to libsndfile/libsndfile
that referenced
this pull request
Mar 31, 2021
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@PhoebeHui , is this my bug? |
Contributor
|
@evpobr, this is not a bug, since you have a new commit, the baseline hash changed, could you update the baseline version by executing command './vcpkg x-add-version --overwrite-version mpg123', and then submit the changes again? |
Contributor
Author
|
@PhoebeHui , ready. |
PhoebeHui
approved these changes
Apr 1, 2021
PhoebeHui
added
info:needs-maintainer-attention
Contributor
|
LGTM, thanks for the fix, looking forward to the libsndfile improvements :) |
Contributor
Author
|
@PhoebeHui , @ras0219-msft , current stable version is 1.26.5. Should i add 1.26.4 too? |
Contributor
|
@evpobr, we prefer to update it with lastest stable revision, thanks again for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix invalid
MPG123_API_VERSIONvalue inmpg123.h.infor Windows platform. It was equal to@API_VERSION@, now it is read fromconfigure.acand set to correct value.See also libsndfile/libsndfile#499.