Skip to content

[vcpkg/scripts] add variable VCPKG_CROSSCOMPILING#16900

Merged
ras0219-msft merged 5 commits intomicrosoft:masterfrom
Neumann-A:add_vcpkg_crosscompiling
Apr 2, 2021
Merged

[vcpkg/scripts] add variable VCPKG_CROSSCOMPILING#16900
ras0219-msft merged 5 commits intomicrosoft:masterfrom
Neumann-A:add_vcpkg_crosscompiling

Conversation

@Neumann-A
Copy link
Contributor

No description provided.

@PhoebeHui PhoebeHui added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Mar 26, 2021
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 30, 2021
@JackBoosY
Copy link
Contributor

LGTM.

Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable should be called "VCPKG_IS_CROSSCOMPILING"

@strega-nil
Copy link
Contributor

Marking requires:discussion since this is an auto-stable new name.

@strega-nil
Copy link
Contributor

@Neumann-A please merge the changes; VCPKG_CROSSCOMPILING has been agreed upon (2F, 1A)

Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
@Neumann-A
Copy link
Contributor Author

@strega-nil done

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ras0219-msft ras0219-msft merged commit 42c437b into microsoft:master Apr 2, 2021
@ras0219-msft
Copy link
Contributor

Thanks!

@Neumann-A Neumann-A deleted the add_vcpkg_crosscompiling branch April 7, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants