Skip to content

[libxml2] add missing GNUInstallDirs to fix pc files#16897

Merged
vicroms merged 11 commits intomicrosoft:masterfrom
Neumann-A:fix_libxml2_pc
Apr 8, 2021
Merged

[libxml2] add missing GNUInstallDirs to fix pc files#16897
vicroms merged 11 commits intomicrosoft:masterfrom
Neumann-A:fix_libxml2_pc

Conversation

@Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Mar 26, 2021

otherwise CMAKE_INSTALL_INCLUDEDIR is not defined

vcpkg/ports/libxml2/CMakeLists.txt

Lines 169 to 174 in 5a10163

set(prefix ${CMAKE_INSTALL_PREFIX})
set(exec_prefix "\${prefix}")
set(libdir ${prefix}/${CMAKE_INSTALL_LIBDIR})
set(includedir ${prefix}/${CMAKE_INSTALL_INCLUDEDIR})
configure_file(libxml-2.0.pc.in libxml-2.0.pc @ONLY)

@PhoebeHui PhoebeHui self-assigned this Mar 26, 2021
@PhoebeHui PhoebeHui added the category:port-bug The issue is with a library, which is something the port should already support label Mar 26, 2021
PhoebeHui
PhoebeHui approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Neumann-A, thanks for the PR!

Please ignore the CI test failure, I will rerun this PR after the baseline issue fixed.

@Neumann-A Neumann-A mentioned this pull request Mar 29, 2021
Merged
@JackBoosY JackBoosY requested a review from PhoebeHui April 6, 2021 22:56
PhoebeHui
PhoebeHui approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate your effort very much!

@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 7, 2021
@vicroms vicroms merged commit d46fc1f into microsoft:master Apr 8, 2021
@Neumann-A Neumann-A deleted the fix_libxml2_pc branch April 8, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicroms vicroms vicroms approved these changes

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Neumann-A @vicroms @PhoebeHui