Skip to content

[libsoundio] Add support for linux backends#16891

Merged
ras0219-msft merged 9 commits intomicrosoft:masterfrom
joe-noel-dev:libsoundio-linux-backends
Apr 2, 2021
Merged

[libsoundio] Add support for linux backends#16891
ras0219-msft merged 9 commits intomicrosoft:masterfrom
joe-noel-dev:libsoundio-linux-backends

Conversation

@joe-noel-dev
Copy link
Contributor

Adds features to build against optional backends (ALSA, JACK or PulseAudio).

@joe-noel-dev
Copy link
Contributor Author

Issue #16864

@PhoebeHui PhoebeHui added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Mar 26, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@JackBoosY
Copy link
Contributor

Waiting for #16904 merged.

@JackBoosY JackBoosY added depends:different-pr This PR or Issue depends on a PR which has been filed and removed requires:author-response labels Mar 26, 2021
@joe-noel-dev joe-noel-dev requested a review from PhoebeHui March 26, 2021 17:39
@joe-noel-dev joe-noel-dev marked this pull request as ready for review March 26, 2021 17:39
@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Mar 29, 2021
@JackBoosY
Copy link
Contributor

Need test all features.

@JackBoosY
Copy link
Contributor

Test passed on x86-windows / x64-windows-static / x64-linux.

@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:all-feature-testing labels Mar 30, 2021
Co-authored-by: Victor Romero <romerosanchezv@gmail.com>
@joe-noel-dev joe-noel-dev requested a review from vicroms April 1, 2021 07:13
@ras0219-msft ras0219-msft merged commit 23c1c65 into microsoft:master Apr 2, 2021
@ras0219-msft
Copy link
Contributor

Thanks for the improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants