Skip to content

[libgwenhywfar] new port#16810

Merged
ras0219-msft merged 9 commits intomicrosoft:masterfrom
wrobelda:libgwenhywfar
Mar 25, 2021
Merged

[libgwenhywfar] new port#16810
ras0219-msft merged 9 commits intomicrosoft:masterfrom
wrobelda:libgwenhywfar

Conversation

@wrobelda
Copy link
Copy Markdown
Contributor

@wrobelda wrobelda commented Mar 21, 2021 •
edited
Loading

Adds new port for libgwenhywfar

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Standard osx and linux. Windows currently unsupported due to a missing Windows libgnutls port.

Yes.

Note that this requires libgnutls fixes from #16807, and is built on top of it.

@wrobelda
[libgnutls] macOS fix; additional optimizations
4395ac4 
- add missing macOS SDK CoreFoundation framework reference
- add OpenSSL compatibility feature
- explicitly disable libdane (was disabled implicitly due to
  a missing libunbound)
- no need for autoconfig
@wrobelda wrobelda force-pushed the libgwenhywfar branch 6 times, most recently from 54272a0 to 7dbd62d Compare March 21, 2021 18:41
@cstim
Copy link
Copy Markdown

cstim commented Mar 21, 2021

Good effort! Thanks for bringing this forward. If you need any additional support on the gwenhywfar/aqbanking side, feel free to ping me. (My own time investment there is very limited currently, but if anything is blocking you, I'd try to help.)

@wrobelda wrobelda marked this pull request as draft March 21, 2021 20:49
@wrobelda
Copy link
Copy Markdown
Contributor Author

wrobelda commented Mar 21, 2021 •
edited
Loading

Good effort! Thanks for bringing this forward. If you need any additional support on the gwenhywfar/aqbanking side, feel free to ping me. (My own time investment there is very limited currently, but if anything is blocking you, I'd try to help.)

Thanks a lot! I do, in fact, have one minor issue – libgwenhywfar checks for OpenSSL by looking for openssl.pc, whereas vcpkg's openssl provides libssl.pc, and from what I see, this is normal. Any idea what to do here (except for patching the .ac)?

@wrobelda wrobelda marked this pull request as ready for review March 22, 2021 00:07
@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 22, 2021
NancyLi1013
NancyLi1013 suggested changes Mar 22, 2021
View reviewed changes
@NancyLi1013 NancyLi1013 added requires:author-response depends:different-pr This PR or Issue depends on a PR which has been filed labels Mar 22, 2021
@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Mar 22, 2021

Seems this PR requires the changes in PR #16807.

ras0219-msft
ras0219-msft reviewed Mar 22, 2021
View reviewed changes
wrobelda and others added 5 commits March 22, 2021 14:23
@wrobelda
[libgnutls] update versions
a85a428
@wrobelda
[libgwenhywfar] new port
db9ec0c
@wrobelda
[libgwenhywfar] add versions
eb8256d
@wrobelda @NancyLi1013
[libgwenhywfar] use semver versioning scheme
b39f6b7 
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@wrobelda @NancyLi1013
[libgwenhywfar] use semver versioning scheme
2cc4509 
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@ras0219-msft ras0219-msft merged commit 70f7385 into microsoft:master Mar 25, 2021
@ras0219-msft
Copy link
Copy Markdown
Contributor

ras0219-msft commented Mar 25, 2021

LGTM, thanks for the PR!

@wrobelda wrobelda mentioned this pull request Mar 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ras0219-msft ras0219-msft ras0219-msft left review comments

@NancyLi1013 NancyLi1013 NancyLi1013 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! depends:different-pr This PR or Issue depends on a PR which has been filed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wrobelda @cstim @NancyLi1013 @ras0219-msft @JackBoosY