Skip to content

[blend2d] Update to beta_2021-03-17#16804

Merged
ras0219-msft merged 2 commits intomicrosoft:masterfrom
ZeeWanderer:blend2d
Mar 23, 2021
Merged

[blend2d] Update to beta_2021-03-17#16804
ras0219-msft merged 2 commits intomicrosoft:masterfrom
ZeeWanderer:blend2d

Conversation

@ZeeWanderer
Copy link
Contributor

@ZeeWanderer ZeeWanderer commented Mar 20, 2021

Updated blend2d to beta_2021-03-17. Updated local asmjit to 2021-03-19.
versioning scheme changed from version-string to version-date
Fixed facepalm BLEND2D_BUILD_NO_JIT usage in portfile. Probably forgot to rename after blend2d changed variable naming to BLEND2D_NO_JIT.

@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label Mar 22, 2021
@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 22, 2021
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the version scheme change, thanks for the PR!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting here that asmjit is available as a vcpkg port: https://github.com/microsoft/vcpkg/blob/master/ports/asmjit/CONTROL

By policy we would really like this to stop being embedded here, however that won't block this update PR.

Copy link
Contributor Author

@ZeeWanderer ZeeWanderer Mar 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blend2d depends on asmjit's CMakeLists directly. I could try to patch it but that would complicate this port by a lot and I am not sure I have the required cmake knowledge to patch it properly to match the original behavior and not cause any additional issues.
https://github.com/blend2d/blend2d/blob/master/CMakeLists.txt#L373
https://github.com/blend2d/blend2d/blob/master/CMakeLists.txt#L391

Relevant comment from the first PR:
#6110 (comment)

@ZeeWanderer ZeeWanderer changed the title [blend2d] Update to beta_2021-03-17 [WIP][blend2d] Update to beta_2021-03-17 Mar 23, 2021
@ZeeWanderer ZeeWanderer changed the title [WIP][blend2d] Update to beta_2021-03-17 [blend2d] Update to beta_2021-03-17 Mar 23, 2021
@ras0219-msft ras0219-msft merged commit e1e3d81 into microsoft:master Mar 23, 2021
@ras0219-msft
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants