[blend2d] Update to beta_2021-03-17#16804
Conversation
ras0219-msft
left a comment
There was a problem hiding this comment.
LGTM after the version scheme change, thanks for the PR!
ports/blend2d/portfile.cmake
Outdated
There was a problem hiding this comment.
Noting here that asmjit is available as a vcpkg port: https://github.com/microsoft/vcpkg/blob/master/ports/asmjit/CONTROL
By policy we would really like this to stop being embedded here, however that won't block this update PR.
There was a problem hiding this comment.
blend2d depends on asmjit's CMakeLists directly. I could try to patch it but that would complicate this port by a lot and I am not sure I have the required cmake knowledge to patch it properly to match the original behavior and not cause any additional issues.
https://github.com/blend2d/blend2d/blob/master/CMakeLists.txt#L373
https://github.com/blend2d/blend2d/blob/master/CMakeLists.txt#L391
Relevant comment from the first PR:
#6110 (comment)
|
Thanks! |
Updated blend2d to beta_2021-03-17. Updated local asmjit to 2021-03-19.
versioning scheme changed from
version-stringtoversion-dateFixed facepalm
BLEND2D_BUILD_NO_JITusage in portfile. Probably forgot to rename after blend2d changed variable naming toBLEND2D_NO_JIT.