[celero] Updated to Celero v2.8.0#16802
[celero] Updated to Celero v2.8.0#16802ras0219-msft merged 7 commits intomicrosoft:masterfrom DigitalInBlue:master
Conversation
DigitalInBlue
commented
Mar 20, 2021
DigitalInBlue
commented
- Updates Celero to v2.8.0
Celero issue #154 is tracking a fix. DigitalInBlue/Celero#154
|
You have to run |
JackBoosY
added
the
category:port-update
| if (VCPKG_LIBRARY_LINKAGE STREQUAL static) | ||
| vcpkg_replace_string(${CURRENT_PACKAGES_DIR}/include/celero/Export.h "ifdef CELERO_STATIC" "if 1") | ||
| endif() | ||
|
|
There was a problem hiding this comment.
@DigitalInBlue, thanks for your pr, please tell me the reason for deleting this function.
There was a problem hiding this comment.
It wasn't documented. I did not observe any side-effects from removing it. If it is necessary, It can be added back in. I was merely trying to remove what I believed to be dead code.
There was a problem hiding this comment.
@DigitalInBlue ,This function will affect the use of celero port, please restore it
scripts/ci.baseline.txt
Outdated
| catch-classic:x86-windows = skip | ||
| ccd:arm-uwp=fail | ||
| ccd:x64-uwp=fail | ||
| celero:x64-windows-static-md=fail |
There was a problem hiding this comment.
I tested locally that the previous version of celero can compile x64-windows-static-md normally. your latest version not compile normally?
|
I "think" this is good. The failures seem to be due to osgEarth, which is not a dependency of Celero.
|
|
@JonLiu1993 Please review for merging. |
JonLiu1993
added
info:needs-maintainer-attention
|
LGTM, thanks for the update! |
* [celero] Updated to Celero v2.8.0 * [celero] Improving static linking support in VCPKG. Celero issue microsoft#154 is tracking a fix. DigitalInBlue/Celero#154 * [celero] Updated to v2.8.1 * [celero] Updated version for VCPKG. * [celero] Updates to better support VCPKG. * [celero] Updated versions. * Update celero.json Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
* [minizip-ng] add new port * [celero] Updated to Celero v2.8.0 (#16802) * [celero] Updated to Celero v2.8.0 * [celero] Improving static linking support in VCPKG. Celero issue #154 is tracking a fix. DigitalInBlue/Celero#154 * [celero] Updated to v2.8.1 * [celero] Updated version for VCPKG. * [celero] Updates to better support VCPKG. * [celero] Updated versions. * Update celero.json Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com> Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
5 participants
