Closed
Conversation
JackBoosY
added
the
category:port-bug
Contributor
|
Does this PR depends on #16791 ? |
Contributor
Author
|
Yes, for both to complete successfully - should I include #16791 in this one, to get all build? |
Contributor
|
@larshg Yes if the changes of these two PRs depend on each other. |
Contributor
Author
|
@JackBoosY #16724 makes PCL and OpenMVC not being build. I have created two PRs to fix those, as you wrote in #16724. Or should I include all changes in the original PR about FLANN, so all is green? |
Contributor
|
@larshg Yes please. We should make all the pipeline test pass. |
Contributor
Author
|
Closing as it is included in #16724 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix? Fixes linking with flann due to [FLANN] Allow to be build as shared lib #16724
Which triplets are supported/not supported? Have you updated the CI baseline?
All triplets.
updated versions/baseline.json .
Does your PR follow the maintainer guide? yes.