[qt5-webengine] Fix issues#16770
Merged
vicroms merged 8 commits intomicrosoft:masterfrom Mar 30, 2021
Merged
Conversation
- add feature "proprietary-codecs" - fix build error due to internal changes how options are passed. - try to fail early on too long build paths instead of late
and only build one configuration to not overstress the ci system
Neumann-A
commented
Mar 18, 2021
Neumann-A
commented
Mar 18, 2021
JackBoosY
added
the
category:port-bug
Contributor
|
Seems CI passed. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ras0219-msft
requested changes
Mar 18, 2021
Contributor
ras0219-msft
left a comment
ras0219-msft
left a comment
There was a problem hiding this comment.
Thanks for the PR! LGTM once we use the official helper.
If you would like it to be a fatal error, we should rely on the official helper to provide the message and then emit the fatal error afterwards.
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Contributor
|
Depends on #16904 |
JackBoosY
added
the
depends:different-pr
JackBoosY
removed
the
depends:different-pr
JackBoosY
approved these changes
Mar 29, 2021
JackBoosY
added
the
info:needs-maintainer-attention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes from #16583
add feature "proprietary-codecs"
fix build error due to internal changes how options are passed.
try to fail early on too long build paths instead of late
wait for CI
Run
vcpkg x-add-version --all