Skip to content

[pcl] PCL VTK9 support.#16700

Closed
ilia-glushchenko wants to merge 1 commit intomicrosoft:masterfrom
ilia-glushchenko:master
Closed

[pcl] PCL VTK9 support.#16700
ilia-glushchenko wants to merge 1 commit intomicrosoft:masterfrom
ilia-glushchenko:master

Conversation

@ilia-glushchenko
Copy link
Contributor

Describe the pull request
At the moment there is no way to build PCL library with the support VTK 9.0. The upstream version of PCL has this issue already fixed. There is a lot of complaints about it. This makes the current PCL version in the VCPKG repo quite hard to use.

  • What does your PR fix? Fixes #
    I updated the current version to upstream.

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    I'm pretty sure everything remains the same.

  • Does your PR follow the maintainer guide?
    I'm not sure about the version in the control file. Technically it did not change. There was no release for some time (last August).

@NancyLi1013 NancyLi1013 changed the title [vcpkg] PCL VTK9 support. [pcl] PCL VTK9 support. Mar 15, 2021
@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Mar 15, 2021
Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that you forgot to update CONTROL file. So could you please update Port-version in CONTROL file?

@NancyLi1013
Copy link
Contributor

Hi @ilia-glushchenko
Thanks for your PR!

rtabmap failed with the following errors on x64-windows and x86-windows triplets:

D:\buildtrees\rtabmap\src\1a6c3ea0ca-12abde5708.clean\corelib\src\util3d_surface.cpp(45): fatal error C1083: Cannot open include file: 'pcl/surface/gp3.h': No such file or directory

@ilia-glushchenko
Copy link
Contributor Author

Working on fixing rtabmap.

@ilia-glushchenko
Copy link
Contributor Author

I've updated the rtabmap to the latest release 0.20.8.
I've also updated the port version in the control file. Thanks for pointing that out.

"name": "rtabmap",
"version-string": "0.20.3",
"port-version": 1,
"version-string": "0.20.8",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version-string": "0.20.8",
"version": "0.20.8",

This might be version, please see doc https://github.com/microsoft/vcpkg/blob/master/docs/specifications/versioning.md#22-package-versions.

"version-string": "0.20.3",
"port-version": 1,
"version-string": "0.20.8",
"port-version": 2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"port-version": 2,
"port-version": 0,

Since this is a new version update, it should be 0. Or remove this field here.

Comment on lines +5 to +6
"version-string": "0.20.8",
"port-version": 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version-string": "0.20.8",
"port-version": 2
"version": "0.20.8",
"port-version": 0

@NancyLi1013
Copy link
Contributor

rtabmap failed with the same error as before:

D:\buildtrees\rtabmap\src\5bb8847365-0132abc1fe.clean\corelib\src\util3d_surface.cpp(45): fatal error C1083: Cannot open include file: 'pcl/surface/gp3.h': No such file or directory

@NancyLi1013
Copy link
Contributor

@ilia-glushchenko

Can you merge maser to resolve the conflicts and also address the review suggestions?

@raahilsha-z
Copy link
Contributor

Found that rtabmap was building Qt/Visualization support despite vcpkg setting -DWITH_QT=OFF. rtabmap 0.20.8 also does not include support for VTK9, as that was only added on May 15, 2021 (introlab/rtabmap#722). I've updated rtabmap to 0.20.13 and also PCL to 1.12.0.99 and created a new pull request here:

#18855

@NancyLi1013
Copy link
Contributor

Thanks for your information. @raahilsha-z
Sounds great. There is no any progress for this PR in a long time. So I think we can close this PR after #18855 merged.

@NancyLi1013
Copy link
Contributor

Closing this PR in flavor of #18855. Thanks for your contribution @ilia-glushchenko.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants