[pcl] PCL VTK9 support.#16700
[pcl] PCL VTK9 support.#16700ilia-glushchenko wants to merge 1 commit intomicrosoft:masterfrom ilia-glushchenko:master
Conversation
NancyLi1013
left a comment
There was a problem hiding this comment.
Seems that you forgot to update CONTROL file. So could you please update Port-version in CONTROL file?
|
Hi @ilia-glushchenko
|
|
Working on fixing |
|
I've updated the |
| "name": "rtabmap", | ||
| "version-string": "0.20.3", | ||
| "port-version": 1, | ||
| "version-string": "0.20.8", |
There was a problem hiding this comment.
| "version-string": "0.20.8", | |
| "version": "0.20.8", |
This might be version, please see doc https://github.com/microsoft/vcpkg/blob/master/docs/specifications/versioning.md#22-package-versions.
| "version-string": "0.20.3", | ||
| "port-version": 1, | ||
| "version-string": "0.20.8", | ||
| "port-version": 2, |
There was a problem hiding this comment.
| "port-version": 2, | |
| "port-version": 0, |
Since this is a new version update, it should be 0. Or remove this field here.
| "version-string": "0.20.8", | ||
| "port-version": 2 |
There was a problem hiding this comment.
| "version-string": "0.20.8", | |
| "port-version": 2 | |
| "version": "0.20.8", | |
| "port-version": 0 |
|
rtabmap failed with the same error as before:
|
|
Can you merge maser to resolve the conflicts and also address the review suggestions? |
|
Found that rtabmap was building Qt/Visualization support despite vcpkg setting -DWITH_QT=OFF. rtabmap 0.20.8 also does not include support for VTK9, as that was only added on May 15, 2021 (introlab/rtabmap#722). I've updated rtabmap to 0.20.13 and also PCL to 1.12.0.99 and created a new pull request here: |
|
Thanks for your information. @raahilsha-z |
|
Closing this PR in flavor of #18855. Thanks for your contribution @ilia-glushchenko. |
Describe the pull request
At the moment there is no way to build PCL library with the support VTK 9.0. The upstream version of PCL has this issue already fixed. There is a lot of complaints about it. This makes the current PCL version in the VCPKG repo quite hard to use.
What does your PR fix? Fixes #
I updated the current version to upstream.
Which triplets are supported/not supported? Have you updated the CI baseline?
I'm pretty sure everything remains the same.
Does your PR follow the maintainer guide?
I'm not sure about the version in the control file. Technically it did not change. There was no release for some time (last August).