[vcpkg] Allow compilation of HEAD_REF-only ports in manifest mode#16613
Closed
PazerOP wants to merge 1 commit intomicrosoft:masterfrom
Closed
[vcpkg] Allow compilation of HEAD_REF-only ports in manifest mode#16613PazerOP wants to merge 1 commit intomicrosoft:masterfrom
PazerOP wants to merge 1 commit intomicrosoft:masterfrom
Conversation
…specific options), and a package requires --head, choose the head ref automatically.
Contributor
|
We are very hesistant to introduce any functionality that produces nondeterministic behavior, especially without loud, obnoxious messages for/from users. Have you considered just defining Note: this is not a supported scenario and breaks binarycaching, but it is a hack that may give you what you want. |
Contributor
|
Closing for now, let me know if the above solution doesn't work for you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires microsoft/vcpkg-tool#24 to work, otherwise it does nothing.
Sort of addresses #12504. More specifically, supports my desired use case:
--headbehavior for all those packages.With the given conditions, it is impossible to build my project. vcpkg will run the manifest install step, then hit my
--head-requiring port, and abort.I cannot use
--head, because not all my vcpkg dependencies are built from source (discord-game-sdk). I also have no desire to be living on the bleeding edge for any third-party dependencies anyway.Theoretically, this change should not break any existing behavior (unless people were relying on vcpkg not working in this situation). It takes a previously non-working scenario (HEAD_REF-only port, manifests, and no
--head) and makes it work in a (in my opinion) reasonable way.What does your PR fix? Somewhat related to [vcpkg|manifest] Missing a way to pass --head to certain dependencies. #12504
Which triplets are supported/not supported? Have you updated the CI baseline?
I do not believe this has any affect for CI pipelines, but I have not studied them in detail. Please correct me if this is wrong.
Does your PR follow the maintainer guide?
To the best of my understanding, yes.