[icu] add host depedency by autoantwort · Pull Request #16577 · microsoft/vcpkg

autoantwort · 2021-03-06T19:48:47Z

Describe the pull request

What does your PR fix? Fixes [qt-base] build failure (icu is build for arm with x64-osx triplet) #16424

Same as #16433, but now with host support in vcpkg as base

ports/icu/portfile.cmake

JackBoosY · 2021-03-09T02:50:42Z

@Neumann-A Do you have any other questions?

Neumann-A · 2021-03-09T20:44:15Z

@JackBoosY: all tools should be moved into ${CURRENT_PACKAGES_DIR}/tools/${PORT}/bin if the bin folder is required instead of having an extra for-cross-compile subfolder.

ports/icu/portfile.cmake

autoantwort · 2021-03-10T01:11:45Z

@JackBoosY: all tools should be moved into ${CURRENT_PACKAGES_DIR}/tools/${PORT}/bin if the bin folder is required instead of having an extra for-cross-compile subfolder.

Ok, it now don't use the for-cross-compile subfolder anymore.

JackBoosY · 2021-03-10T01:39:17Z

Shoud we wait for PR #16627?

autoantwort · 2021-03-10T10:22:01Z

Shoud we wait for PR #16627?

Then we can use ${HOST_TRIPLET} instead of ${_HOST_TRIPLET}

autoantwort · 2021-03-11T23:13:50Z

I don't think that the x86_windows pipeline failure is caused by the latest commit.

ras0219-msft

This looks really great and I'm excited to merge!

I agree with @Neumann-A that it's probably better to use vcpkg_internal_get_cmake_vars() instead of hardcoding -arch x86_64.

ras0219-msft · 2021-03-16T19:06:00Z

ports/icu/portfile.cmake

+# Install executables from ${CURRENT_BUILDTREES_DIR}/${RELEASE_TRIPLET}/bin to /tools/icu/bin
+file(GLOB ICU_TOOLS
+    ${CURRENT_BUILDTREES_DIR}/${RELEASE_TRIPLET}/bin/*${VCPKG_HOST_EXECUTABLE_SUFFIX}
+    ${CURRENT_PACKAGES_DIR}/lib/icu*${ICU_VERSION_MAJOR}.dll


It would probably be better to use vcpkg_copy_tool_dependencies() instead of manually globbing the DLLs. This function may be updated to support .so and .dylib in the future.

Additionally, we could probably replace the original purge of the bin directory above (line ~340ish) with vcpkg_copy_tools(). Even if vcpkg_copy_tools() isn't applicable, it would be better to move those files to the tools directory instead of deleting and re-copying from the buildtrees.

Additionally, we could probably replace the original purge of the bin directory above (line ~340ish) with vcpkg_copy_tools()

The problem with vcpkg_copy_tools() is, that it copies to ${CURRENT_PACKAGES_DIR}/tools/${PORT}, but the files must be copied to ${CURRENT_PACKAGES_DIR}/tools/${PORT}/bin

you could use set(PORT "${PORT}/bin") but you could also add an option like SUBDIR or DESTINATION to vcpkg_copy_tools

I have added a DESTINATION parameter to vcpkg_copy_tools

The problem with vcpkg_copy_tool_dependencies is, that it does not copy the tool dependencies ...
On my mashine it copies nothing and cmake can't start the applications because of missing dlls

ports/icu/vcpkg.json

Refolve conflicts/updating version files

JackBoosY · 2021-04-21T03:55:52Z

Will rerun the osx pipeline test later.

JackBoosY · 2021-04-30T17:00:31Z

When building libheif:x64-linux:

CMake Error at gdk-pixbuf/CMakeLists.txt:18 (install):
  install TARGETS given no LIBRARY DESTINATION for module target
  "pixbufloader-heif".

autoantwort · 2021-04-30T17:01:43Z

When building libheif:x64-linux:

CMake Error at gdk-pixbuf/CMakeLists.txt:18 (install):
  install TARGETS given no LIBRARY DESTINATION for module target
  "pixbufloader-heif".

I think all the ci errors are unrelated to this PR

JackBoosY · 2021-04-30T17:03:49Z

@autoantwort I've got the failure log, will restart pipeline test now.

autoantwort · 2021-04-30T17:11:14Z

When building libheif:x64-linux

Maybe #17593 fixes that

autoantwort · 2021-04-30T18:36:39Z

When building libheif:x64-linux

Maybe #17593 fixes that

Ok seems that a simple rerun solved the problem :)

Neumann-A · 2021-04-30T19:18:37Z

Ok seems that a simple rerun solved the problem :)

that is because gdk-pixbuf will not be restored in the rerun and so libheif does not pick it up and installs successfully.

strega-nil-ms

double documentation! o noes

docs/maintainers/vcpkg_copy_tools.md

scripts/cmake/vcpkg_copy_tools.cmake

autoantwort

Seems that the DESTINATION option was also added in another PR

docs/maintainers/vcpkg_copy_tools.md

scripts/cmake/vcpkg_copy_tools.cmake

autoantwort · 2021-05-01T11:46:33Z

Most random ci errors were resolved by a rerun, now this PR only depends on #17610

strega-nil-ms · 2021-05-01T16:53:20Z

/azp run

azure-pipelines · 2021-05-01T16:53:38Z

Azure Pipelines successfully started running 1 pipeline(s).

strega-nil-ms · 2021-05-01T18:17:00Z

Thanks @autoantwort :)

[icu] add host depedency (microsoft#16577)

Neumann-A reviewed Mar 6, 2021

View reviewed changes

ports/icu/portfile.cmake Outdated Show resolved Hide resolved

autoantwort marked this pull request as ready for review March 7, 2021 23:22

Neumann-A reviewed Mar 7, 2021

View reviewed changes

ports/icu/portfile.cmake Outdated Show resolved Hide resolved

JonLiu1993 assigned JackBoosY Mar 8, 2021

JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Mar 8, 2021

Neumann-A reviewed Mar 9, 2021

View reviewed changes

ports/icu/portfile.cmake Outdated Show resolved Hide resolved

JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Mar 10, 2021

autoantwort mentioned this pull request Mar 10, 2021

[icu] fix mac os x64 build on apple arm #16433

Closed

JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Mar 13, 2021

autoantwort mentioned this pull request Mar 15, 2021

[icu] BUILD_FAILURE when building icu x64-windows-dbg on Windows 10 #16712

Closed

ras0219-msft requested changes Mar 16, 2021

View reviewed changes

JackBoosY added the requires:author-response label Mar 17, 2021

autoantwort added 12 commits March 17, 2021 20:26

[icu] introduce host dependency

2807910

add version files

35ff48d

[icu] host dependency windows, update ci baseline

31e061a

add version files

62eaa95

[icu] add debug messages

5145658

[icu] do not depend on buildtree, install required files instead

0424614

[icu] set env variable for dynamic libs

8094631

[icu] find dlls for windows

2dc5974

[icu] copy dlls

81e94e0

[icu] cleanup, fix apple arm targets

736bced

add version files

fa8524b

[icu] no for-cross-compile subfolder

5ec4fe9

JackBoosY added the requires:author-response label Apr 20, 2021

Merge branch 'master' into icu-hosts

f39a261

Refolve conflicts/updating version files

JackBoosY removed the requires:author-response label Apr 20, 2021

add version files

7a8ae4e

Trigger Build

2cf5c8f

JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 23, 2021

BillyONeal and others added 2 commits April 29, 2021 13:03

Merge remote-tracking branch 'origin/master' into HEAD

50a12a1

Trigger Build

048b17b

JackBoosY removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 30, 2021

strega-nil-ms approved these changes May 1, 2021

View reviewed changes

docs/maintainers/vcpkg_copy_tools.md Outdated Show resolved Hide resolved

scripts/cmake/vcpkg_copy_tools.cmake Outdated Show resolved Hide resolved

Apply suggestions from code review

5b45a3e

autoantwort commented May 1, 2021

View reviewed changes

docs/maintainers/vcpkg_copy_tools.md Outdated Show resolved Hide resolved

scripts/cmake/vcpkg_copy_tools.cmake Outdated Show resolved Hide resolved

autoantwort and others added 2 commits May 1, 2021 03:13

Apply suggestions from code review

a70426a

Trigger Build

d0ec5ba

strega-nil-ms merged commit 4b6289b into microsoft:master May 1, 2021

sthagen added a commit to sthagen/microsoft-vcpkg that referenced this pull request May 2, 2021

Merge pull request #138 from microsoft/master

f1ffdaf

[icu] add host depedency (microsoft#16577)

zapcity mentioned this pull request Aug 13, 2021

[icu:x64-windows-static] build failure #18086

Closed

autoantwort deleted the icu-hosts branch September 1, 2021 13:54

bamo-volue mentioned this pull request Jan 4, 2024

[icu] Build error #35709

Open

Conversation

autoantwort commented Mar 6, 2021

Uh oh!

Uh oh!

Uh oh!

JackBoosY commented Mar 9, 2021

Uh oh!

Neumann-A commented Mar 9, 2021

Uh oh!

Uh oh!

autoantwort commented Mar 10, 2021

Uh oh!

JackBoosY commented Mar 10, 2021

Uh oh!

autoantwort commented Mar 10, 2021

Uh oh!

autoantwort commented Mar 11, 2021

Uh oh!

ras0219-msft left a comment

Choose a reason for hiding this comment

Uh oh!

ras0219-msft Mar 16, 2021

Choose a reason for hiding this comment

Uh oh!

ras0219-msft Mar 16, 2021

Choose a reason for hiding this comment

Uh oh!

autoantwort Mar 17, 2021

Choose a reason for hiding this comment

Uh oh!

Neumann-A Mar 17, 2021

Choose a reason for hiding this comment

Uh oh!

autoantwort Mar 18, 2021

Choose a reason for hiding this comment

Uh oh!

autoantwort Mar 18, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JackBoosY commented Apr 21, 2021

Uh oh!

JackBoosY commented Apr 30, 2021

Uh oh!

autoantwort commented Apr 30, 2021

Uh oh!

JackBoosY commented Apr 30, 2021

Uh oh!

autoantwort commented Apr 30, 2021

Uh oh!

autoantwort commented Apr 30, 2021

Uh oh!

Neumann-A commented Apr 30, 2021

Uh oh!

strega-nil-ms left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

autoantwort left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

autoantwort commented May 1, 2021

Uh oh!

strega-nil-ms commented May 1, 2021

Uh oh!

azure-pipelines bot commented May 1, 2021

Uh oh!

strega-nil-ms commented May 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants