Don't copy svm-toy if not on Windows#16501
Merged
ras0219-msft merged 4 commits intomicrosoft:masterfrom Mar 10, 2021
Merged
Conversation
svm-toy is only compiled on Windows, so should only be copied on Windows.
JackBoosY
suggested changes
Mar 3, 2021
Contributor
JackBoosY
left a comment
JackBoosY
left a comment
There was a problem hiding this comment.
Please bump the port version. See documentation.
Also please run command vcpkg x-add-version --all then commit the changes.
JackBoosY
added
category:port-bug
|
|
Contributor
Author
|
@JackBoosY I updated to the new vcpkg.json manifest format along the way. I bumped to port-version 1, since I assumed default is 0 if no port-version field exists. |
added 2 commits
March 3, 2021 22:18
JackBoosY
approved these changes
Mar 4, 2021
JackBoosY
added
info:needs-maintainer-attention
Contributor
|
Awesome work, thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
svm-toy is only compiled on Windows, so should only be copied on Windows.
Describe the pull request
What does your PR fix? Fixes platform dependence on libsvm with tool feature enabled.
Which triplets are supported/not supported? Have you updated the CI baseline? x64-linux
Does your PR follow the maintainer guide?