-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[cudnn] auto-download only if cuda version matches #16413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
537a782
[cudnn] auto-download only if cuda version matches
cenit 3b7629d
[cudnn] auto download also for cuda 10.2
cenit 9bfec00
[cudnn] update version ref
cenit 19dcd4c
Update ports/cuda/vcpkg_find_cuda.cmake
cenit b1823a8
Update ports/cuda/vcpkg_find_cuda.cmake
cenit 2b9f218
Update ports/cudnn/portfile.cmake
cenit 659d286
apply review fixes
cenit 413eff0
fix baseline refs
cenit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| Source: cuda | ||
| Version: 10.1 | ||
| Port-Version: 5 | ||
| Port-Version: 7 | ||
| Description: A parallel computing platform and programming model | ||
| Homepage: https://developer.nvidia.com/cuda-toolkit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| Source: cudnn | ||
| Version: 7.6 | ||
| Port-Version: 4 | ||
| Version: 7.6.5 | ||
| Description: NVIDIA's cuDNN deep neural network acceleration library | ||
| Build-Depends: cuda | ||
| Supports: (windows|linux)&x64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove these paths?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a working cuda installation should have CUDA_PATH set up AFAIK.
Those variables just show up for each installed version (might even be all of them on a system) but do not express the user choice between them if multiple are available, which is done with the single CUDA_PATH.
Also, i'd lower the minimum cuda version we require, since it's not strictly installed by us (on the contrary, in this case we should support the broadest possible range of version, right?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ras0219 these paths aren't standard and are version-specific. I'm unaware of any environment in which these paths are set.
CUDA_PATHorCUDA_HOMEis standard across many versions of CUDA.