Skip to content

[brotli] add iOS support#16397

Merged
ras0219-msft merged 3 commits intomicrosoft:masterfrom
jwtowner:brotli-ios
Feb 26, 2021
Merged

[brotli] add iOS support#16397
ras0219-msft merged 3 commits intomicrosoft:masterfrom
jwtowner:brotli-ios

Conversation

@jwtowner
Copy link
Copy Markdown
Contributor

@jwtowner jwtowner commented Feb 24, 2021

This adds support for building brotli on iOS triplets.

For iOS the BUNDLE DESTINATION parameter must be specified when calling install in CMakeLists.txt, and so this PR sets it to the same path as the RUNTIME DESTINATION.

Triplets that now compile with this change:

arm64-ios
x64-ios

@jwtowner
[brotli] add iOS support
eeee174 
This commit adds support for iOS by modifying the CMakeLists.txt
file to specify the BUNDLE DESTINATION parameter during install,
which is required for iOS builds.
@jwtowner
[brotli] update control file
9873871
@jwtowner
[brotli] update versions
0d5756d
@NancyLi1013 NancyLi1013 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. labels Feb 25, 2021
@jwtowner
Copy link
Copy Markdown
Contributor Author

jwtowner commented Feb 25, 2021

I take it the failure in x86_windows due to freeopcua is unrelated?

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Feb 25, 2021

Yes, freeopcua failed with insufficient disk space:

CMakeFiles\opcuaprotocol.dir/manifest.res" failed (exit code 1201) with the following output:
LINK : fatal error LNK1201: error writing to program database 'D:\buildtrees\freeopcua\x86-windows-dbg\opcuaprotocold.pdb'; check for insufficient disk space, invalid path, or insufficient privilege
ninja: build stopped: subcommand failed.

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Feb 25, 2021

@strega-nil
Could you please help take a look? Thanks.

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Feb 26, 2021

The failure disappeared after rerun.

LGTM now, thanks for your PR @jwtowner.

@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Feb 26, 2021
@ras0219-msft ras0219-msft merged commit b5e6d68 into microsoft:master Feb 26, 2021
@ras0219-msft
Copy link
Copy Markdown
Contributor

ras0219-msft commented Feb 26, 2021

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jwtowner @NancyLi1013 @ras0219-msft