[rsasynccpp] Add new port (Rstein.AsyncCpp)#16380
[rsasynccpp] Add new port (Rstein.AsyncCpp)#16380ras0219-msft merged 6 commits intomicrosoft:masterfrom
Conversation
|
|
renestein
force-pushed
the
Rstein.AsyncCpp
branch
4 times, most recently
from
a1d4bda to
8a37024
Compare
renestein
force-pushed
the
Rstein.AsyncCpp
branch
from
8a37024 to
0e68ad3
Compare
JackBoosY
added
the
category:new-port
renestein
force-pushed
the
Rstein.AsyncCpp
branch
from
6ab7017 to
31fd9fc
Compare
scripts/ci.baseline.txt
Outdated
| rsasynccpp:arm-uwp=fail | ||
| rsasynccpp:x64-linux=fail | ||
| rsasynccpp:x64-osx=fail | ||
| rsasynccpp:x64-windows-static=fail |
There was a problem hiding this comment.
You declared ONLY_STATIC_LIBRARY, but why it failed on x64-windows-static?
There was a problem hiding this comment.
@JackBoosY I think that '64-windows-static' requires static CRT (/MT switch) and I am not sure if the /MT switch is a good idea.
AFAIK new static library project in Visual Studio ale sets /MD switch.
There was a problem hiding this comment.
I'm confused.
The result of setting ONLY_STATIC_LIBRARY under dynamic and building should be consistent with the result of windows-static.
There was a problem hiding this comment.
@JackBoosY The similar problem is described here.
#4274
Maybe I am wrong, but it appears to me that vcpkg (some triplets in vcpkg) uses the term 'static' for two related, but different things.
- Static library itself (e. g. static build of the rsasynccpp).
- Static linkage of the CRT library. (/MT /MTd).
set(VCPKG_CRT_LINKAGE )
set(VCPKG_LIBRARY_LINKAGE)
There was a problem hiding this comment.
Anyway, I have created new solution configurations and updated the portfile.
renestein
force-pushed
the
Rstein.AsyncCpp
branch
from
5776b70 to
29ea0d4
Compare
|
Thanks for the new library! |
[rsasynccpp] Add new port (Rstein.AsyncCpp) (microsoft#16380)
| rsasynccpp:arm64-windows=fail | ||
| rsasynccpp:arm-uwp=fail | ||
| rsasynccpp:x64-linux=fail | ||
| rsasynccpp:x64-osx=fail |
There was a problem hiding this comment.
We should remove these codes...
|
Thanks! |
3 participants
New Port - Rstein.AsyncCpp library.
The RStein.AsyncCpp library is a set of types that should be familiar for anyone who knows the Task Parallel Library (TPL) for .NET (C#). In addition, this library contains simple DataFlow, threadless actors (agents), functional combinators for the Task class, useful async primitives (AsyncSemaphore, AsyncProducerConsumerCollection, CancellationToken, CancellationTokenSource, AsyncMutex, SynchronizationContext, SynchronizationContextScope ...).
Rstein.AsyncCpp
Which triplets are supported/not supported? Have you updated the CI baseline?
I have tested the library on x86-windows and x64-windows. UWP triplets seem to be working as well.
Does your PR follow the maintainer guide?
I am not sure if the feature 'lib-cl-win-legacy-await' is acceptable, but I didn't find a better way.