[boost-context] fix linux -> windows cross compile#16378
Merged
ras0219-msft merged 2 commits intomicrosoft:masterfrom Feb 26, 2021
Merged
[boost-context] fix linux -> windows cross compile#16378ras0219-msft merged 2 commits intomicrosoft:masterfrom
ras0219-msft merged 2 commits intomicrosoft:masterfrom
Conversation
Contributor
|
usually boost port files are auto generated. it might be better to fix the generating script in order to not loose your mods the next update |
Contributor
Author
|
Yeah the script https://github.com/microsoft/vcpkg/blob/master/scripts/boost/generate-ports.ps1#L185 uses the |
PhoebeHui
added
the
category:port-feature
PhoebeHui
approved these changes
Feb 24, 2021
Contributor
PhoebeHui
left a comment
PhoebeHui
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR!
PhoebeHui
added
the
info:needs-maintainer-attention
Contributor
|
This PR LGTM, however should this fragment always be applied to all boost builds? Or is boost-context the only library that cares about |
ras0219-msft
approved these changes
Feb 24, 2021
Contributor
Author
No this is a boost-context only option. See here. |
Contributor
|
LGTM, thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request