Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tensorflow] upgrade to 2.4.1 #16364

Merged
merged 222 commits into from
Mar 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
222 commits
Select commit Hold shift + click to select a range
0ab169d
fix build issues occurring from default bazel config being used becau…
Jul 23, 2020
543e19d
[tensorflow-cc] Update CONTROL and ci.baseline.txt
LilyWangL Jul 24, 2020
820c455
fix also applies to windows static build
Jul 24, 2020
9643548
fix debug and static builds as well as library naming for non-linux
Aug 11, 2020
4860a01
upgrade tensorflow from v1.14 to v2.3
Aug 15, 2020
dd6d89f
fix execute process macro
Aug 15, 2020
0d611be
extend overriden execute_process to more than one COMMAND as there ac…
Aug 17, 2020
d3121ce
Merge pull request #1 from microsoft/master
jgehw Aug 17, 2020
ee969d7
merge branch 'fix-execute-process-macro2' into 'fix-static-builds-and…
Aug 17, 2020
ad5ca5f
added another patch required for tensorflow v2.3, fixed path and work…
Aug 18, 2020
c743e49
Revert "incorporate changes from microsoft:master"
jgehw Aug 18, 2020
2571bd1
Merge pull request #2 from jgehw/revert-1-master
jgehw Aug 18, 2020
98ecc0c
Revert "Revert "incorporate changes from microsoft:master""
jgehw Aug 18, 2020
ab8fdf7
Merge branch 'master' of https://github.com/microsoft/vcpkg
Aug 18, 2020
36143ac
Merge branch 'master' of https://github.com/microsoft/vcpkg
Aug 20, 2020
ea07bb9
final fixes for static build + improving out messages
Aug 20, 2020
a12d22f
enabling linux and osx in CI to see if it works now
Aug 20, 2020
6c34a08
Merge branch 'master' into fix-static-builds-and-more
jgehw Aug 20, 2020
6e31cd6
simplified code, fixed version numbers, fixed generated include cmake…
Aug 21, 2020
afc7f1e
fix failing postbuild check on handcrafted empty dummy library by spr…
Aug 21, 2020
898bbbe
remove dead code commit by mistake again
Aug 21, 2020
2ca1f94
Merge branch 'fix-static-builds-and-more' of https://github.com/jgehw…
Aug 21, 2020
1866a82
Merge branch 'master' of https://github.com/microsoft/vcpkg
Aug 21, 2020
350b151
improvements from code review
Aug 21, 2020
630e890
cleaner fix for debug code
Aug 21, 2020
2c66c4b
find pip3 in PATH (PYTHON3_DIR apparently not valid for pip3)
Aug 22, 2020
40954e4
fix error in python helper script
Aug 22, 2020
9451d33
Merge branch 'master' of https://github.com/microsoft/vcpkg
Aug 22, 2020
d198bf1
fix wrong libname in postbuild script
Aug 24, 2020
f6acaeb
fix python detection + switch to python on msys2 (instead of embedded…
Aug 24, 2020
efd0c93
fix order of arguments
jgehw Aug 24, 2020
5c1f7ae
fix command (it may contain spaces such as C:\Program Files\...)
jgehw Aug 25, 2020
3b95e18
revert last commit (root cause for CI failures is something different…
jgehw Aug 25, 2020
bfffec6
fix regex comparision
jgehw Aug 25, 2020
c9d08e9
fix linebreaks in generated file
jgehw Aug 25, 2020
2de4912
merge branch 'fix-execute-process-macro2' into 'fix-static-builds-and…
jgehw Aug 25, 2020
cdfdc65
fix CRT linkage
jgehw Aug 25, 2020
c8c12b8
refactor implemenation to avoid as much code duplication as possible …
jgehw Aug 25, 2020
71cf605
Merge branch 'master' into fix-static-builds-and-more
jgehw Aug 26, 2020
9f67738
Merge branch 'fix-static-builds-and-more' of https://github.com/jgehw…
jgehw Aug 26, 2020
5d09b86
fix version numbers in helper scripts
jgehw Aug 26, 2020
6cb4e5b
enable work-around for Windows until bazel fix is available
jgehw Aug 26, 2020
5376c01
install missing python3-pip on linux
jgehw Aug 26, 2020
692c742
fix linux build by patching
jgehw Aug 28, 2020
fbbde32
Merge branch 'master' of https://github.com/microsoft/vcpkg
jgehw Aug 28, 2020
37c3528
merge branch 'master' into 'fix-static-builds-and-more'
jgehw Aug 28, 2020
1246969
apply timeout feature now available via merged master branch
jgehw Aug 28, 2020
c918214
correct linux build patch
jgehw Aug 28, 2020
e78a3df
improve debug build patches
jgehw Aug 28, 2020
9103128
improve linux patch
jgehw Aug 28, 2020
fc4404a
temporarily add debug to inspect what's going on on macOS CI
jgehw Aug 29, 2020
cc3823d
Merge branch 'master' of https://github.com/microsoft/vcpkg
jgehw Aug 29, 2020
74cc334
remove temporary debug code and fix static linking scripts for linux …
jgehw Aug 30, 2020
ee1082f
fix regex escaping
jgehw Aug 30, 2020
381066a
fix ambiguous match while grepping for the framework link command
jgehw Aug 30, 2020
006a21a
extend fix of ambiguous match while grepping for the framework link c…
jgehw Aug 31, 2020
f7ee6c6
Merge branch 'master' of https://github.com/microsoft/vcpkg
jgehw Aug 31, 2020
b667b99
Merge branch 'master' into fix-static-builds-and-more
jgehw Sep 1, 2020
37f79c6
Merge branch 'master' of https://github.com/microsoft/vcpkg
jgehw Sep 1, 2020
d77a47c
fix what merge of master broke
jgehw Sep 1, 2020
74c4fc8
Merge branch 'master' into fix-static-builds-and-more
jgehw Sep 1, 2020
f81922c
fix more what got broken by merging master
jgehw Sep 1, 2020
f0d1c89
Merge branch 'master' of https://github.com/microsoft/vcpkg into master
jgehw Sep 2, 2020
3d8e2f2
remove "unofficial" from filename
jgehw Sep 2, 2020
2051e9e
added switch do distinct classic and manifest mode when generating co…
jgehw Sep 2, 2020
1241b67
create symlinks for libraries without version number
jgehw Sep 3, 2020
1da9b92
fix linux postbuild script
jgehw Sep 3, 2020
3df3b9b
Merge branch 'master' of https://github.com/microsoft/vcpkg into master
jgehw Sep 3, 2020
900512c
Merge branch 'master' into fix-static-builds-and-more
jgehw Sep 3, 2020
fb609b5
temporarily disable code making problems
jgehw Sep 3, 2020
ec68741
add note for linking on Linux and macOS
jgehw Sep 4, 2020
84af4a0
forget to add README file in previous commit
jgehw Sep 4, 2020
7f599a2
add file forgotton in macro fixing patch
jgehw Sep 4, 2020
067323c
Merge branch 'master' of https://github.com/microsoft/vcpkg into master
jgehw Sep 8, 2020
b8e9523
Merge branch 'master' of https://github.com/microsoft/vcpkg into master
jgehw Sep 10, 2020
bcda036
Merge branch 'master' into fix-static-builds-and-more
jgehw Sep 10, 2020
e4f15a8
fix python library path
jgehw Sep 11, 2020
da3cb5a
fix macOS static link command
jgehw Sep 11, 2020
7273f86
update linkage instructions in README
jgehw Sep 11, 2020
fdc5cf6
Update ports/tensorflow-cc/CONTROL
JackBoosY Sep 14, 2020
05be090
Update ports/tensorflow-cc/portfile.cmake
JackBoosY Sep 14, 2020
faf3447
Update scripts/ci.baseline.txt
JackBoosY Sep 14, 2020
3787012
use vcpkg_execute_required_process
jgehw Sep 14, 2020
0877229
pass C_FLAGS and CXX_FLAGS to bazel
jgehw Sep 14, 2020
eaf1d7c
fix INTERFACE_INCLUDE_DIRECTORIES
jgehw Sep 14, 2020
0a986ac
fix optional c/cxx arguments
jgehw Sep 17, 2020
bb63d8c
also add linker opts
jgehw Sep 22, 2020
79076a2
Merge branch 'pass-cflags-to-bazel' into fix-static-builds-and-more
jgehw Sep 30, 2020
ca81fb9
update README
jgehw Sep 30, 2020
8e16503
merge static libs into one
Oct 1, 2020
8677bdb
update README
Oct 1, 2020
39312c7
Merge branch 'master' of https://github.com/microsoft/vcpkg
Oct 1, 2020
79a26c8
Merge branch 'master' into fix-static-builds-and-more
Oct 1, 2020
6384898
Merge branch 'master' of https://github.com/microsoft/vcpkg into master
jgehw Oct 9, 2020
533895b
Merge branch 'master' into fix-static-builds-and-more
jgehw Oct 9, 2020
d3e3c2a
Merge branch 'master' of https://github.com/microsoft/vcpkg
Oct 10, 2020
2ad839b
Merge branch 'master' of https://github.com/microsoft/vcpkg into master
jgehw Oct 15, 2020
f4e64da
Merge branch 'master' of https://github.com/microsoft/vcpkg into master
jgehw Oct 21, 2020
180925f
quote python path (it might contain spaces that don't get escaped ins…
jgehw Oct 22, 2020
4584d3a
fix python path also for static build
jgehw Oct 24, 2020
49f6f38
add arm(64) as currently unsupported arch
jgehw Oct 24, 2020
a174637
bazel 3.7 is available -> remove workaround
jgehw Oct 24, 2020
292013f
update README, remove necessary c-ares from deps
jgehw Oct 24, 2020
f8e004c
update msys package
Oct 24, 2020
a259f33
Merge branch 'fix-static-builds-and-more' of https://github.com/jgehw…
Oct 24, 2020
0ab5c4e
add uwp specific options, and minor general improvements
Oct 25, 2020
920af34
fix string replace
Oct 25, 2020
6594588
fix control file and windows path separator
Oct 25, 2020
0a22920
revert backslashes-fix -- the root cause was missing .exe extension
Oct 25, 2020
4ef9252
upgrade to tf 2.3.1
Oct 25, 2020
41e2f80
fix hard-coded version
Oct 25, 2020
7fa2689
Merge branch 'master' into fix-static-builds-and-more
jgehw Oct 26, 2020
fe1d24c
Merge branch 'master' of https://github.com/microsoft/vcpkg into master
jgehw Oct 27, 2020
ff1d1c9
Merge branch 'master' into fix-static-builds-and-more
jgehw Oct 27, 2020
f064862
remove uwp work-in-progress code so that PR can be merged
jgehw Oct 27, 2020
a68ae07
add [tensorflow] C API port
jgehw Oct 27, 2020
b3a6018
missing in previous commit
jgehw Oct 27, 2020
e2b95d1
fix include file
jgehw Oct 27, 2020
83149c4
remove unnecessary suffix
jgehw Oct 28, 2020
4840250
update README and print out usage info in portfile
jgehw Nov 4, 2020
24831cc
Merge branch 'fix-static-builds-and-more' into add-tensorflow-c
jgehw Nov 4, 2020
b2b19a6
add UWP patches
jgehw Nov 4, 2020
0f052b2
fix uwp patch file
jgehw Nov 5, 2020
3141fb9
fix patch again
jgehw Nov 5, 2020
756dca2
fix patch again
jgehw Nov 5, 2020
a8e88d7
fix patch again
jgehw Nov 5, 2020
2f73611
move options from command line to .bazelrc
jgehw Nov 5, 2020
73bf321
fix include paths
jgehw Nov 5, 2020
0bb4819
work around bazel restriction "The include path 'D:/buildtrees/tensor…
jgehw Nov 5, 2020
9f5ef93
go for a completely different approach: force-include uwppatch.h
jgehw Nov 5, 2020
5a05ca7
fix include path again
jgehw Nov 5, 2020
58ae817
choose different include location, which is available in bazel build …
jgehw Nov 5, 2020
9ad7b7d
fix compile errors
jgehw Nov 5, 2020
5c7817b
update header (getenv redefinition)
jgehw Nov 5, 2020
1be36c5
next try to get patched headers to work
jgehw Nov 6, 2020
b21b6fe
another try to fix include paths
jgehw Nov 6, 2020
9a5af3d
update patched header, bazel has its own naming for target triplet
jgehw Nov 8, 2020
c067c87
yet another try to fix patched include path
jgehw Nov 8, 2020
d129bd2
next try to fix includes: patch bazel deps where required
jgehw Nov 10, 2020
cfbdc9c
fix patch
jgehw Nov 11, 2020
3898892
Merge branch 'master' of https://github.com/microsoft/vcpkg into master
jgehw Nov 12, 2020
06f7a9c
Merge branch 'master' into add-tensorflow-c
jgehw Nov 12, 2020
e1c55ed
Update ports/tensorflow-cc/CONTROL
jgehw Nov 14, 2020
51cae0d
Update ports/tensorflow/portfile.cmake
jgehw Nov 14, 2020
52a905d
follow-up to code review
jgehw Nov 14, 2020
5e5c7ab
extend patch (further build deps)
jgehw Nov 15, 2020
d954930
fix suffix parameter
jgehw Nov 15, 2020
12a96ce
add more build deps
jgehw Nov 16, 2020
f3351f5
fix quoting
jgehw Nov 16, 2020
77559a6
Merge branch 'master' of https://github.com/microsoft/vcpkg into master
jgehw Nov 16, 2020
26cbca8
Merge branch 'master' into add-tensorflow-c
jgehw Nov 16, 2020
43039bc
extend linux patch
jgehw Nov 16, 2020
3e7d9b4
fix patch
jgehw Nov 16, 2020
bb66874
extend patch again
jgehw Nov 16, 2020
a1babea
yet another deps fix
jgehw Nov 16, 2020
d005d4d
another try to fix quoting of possibly empty string parameter
jgehw Nov 16, 2020
b28359c
add another deps patch
jgehw Nov 16, 2020
758a78f
extend patch again
jgehw Nov 17, 2020
6374836
different approach to fix empty string arguments
jgehw Nov 17, 2020
65c3073
Merge branch 'add-tensorflow-c' into add-tf-uwp
jgehw Nov 17, 2020
cf093d1
fix portfiles, add more bazel deps
jgehw Nov 17, 2020
e45fdcf
update list of headers for tensorflow 2.3.1 (was still 2.3.0)
jgehw Nov 17, 2020
45912df
update list of headers for v2.3.1
jgehw Nov 17, 2020
f9f8572
extend bazel deps path again
jgehw Nov 17, 2020
3b3ef9f
Update ports/tensorflow/CONTROL
jgehw Nov 18, 2020
ea05d03
fix bazel deps, bump port version
jgehw Nov 18, 2020
1665fd2
add more bazel deps
jgehw Nov 18, 2020
bb1a320
move common stuff into tensorflow-common as discussed in review
jgehw Nov 20, 2020
e0e437d
go for a different approach (patch bazel toolchain) as adding bazel d…
jgehw Nov 20, 2020
d468baf
Apply suggestions from code review
jgehw Nov 21, 2020
493fdb6
yet again a completely different approach to fix the include path
jgehw Nov 23, 2020
15ab0e7
fix path
jgehw Nov 23, 2020
4894eb2
fix path again
jgehw Nov 24, 2020
dd82b43
Merge branch 'add-tensorflow-c' into add-tf-uwp
jgehw Nov 24, 2020
d763508
merge changes from C port
jgehw Nov 24, 2020
bd71978
fix cmake variable replacement (apparently @ cannot be escaped...)
jgehw Nov 25, 2020
9e64aef
Merge branch 'master' into add-tf-uwp
jgehw Nov 25, 2020
c5a4d61
try again without escaping
jgehw Nov 26, 2020
d5014be
use absolute path
jgehw Nov 30, 2020
e9e8031
fix escaping
jgehw Dec 1, 2020
7a11dda
calculate absolute path
jgehw Dec 2, 2020
6a40066
fix replacement in configure_file
jgehw Dec 2, 2020
4e1c29c
handle directory exists error
jgehw Dec 2, 2020
d17b840
convert cygpath to windows path
jgehw Dec 2, 2020
a1b86df
overcome backslash / escaping issues
jgehw Dec 2, 2020
7bfae95
Merge branch 'master' of https://github.com/microsoft/vcpkg
jgehw Dec 3, 2020
6384419
try include with build-root-relative path
jgehw Dec 7, 2020
fc75c56
apply work-around until proper solution is available
jgehw Feb 4, 2021
3c9d47e
Merge branch 'master' of https://github.com/microsoft/vcpkg
jgehw Feb 4, 2021
57c8d3c
Merge branch 'master' into add-tf-uwp
jgehw Feb 4, 2021
f0804f1
merge master
jgehw Feb 4, 2021
b69ba43
resolved conflicts
jgehw Feb 4, 2021
15dda4d
Revert "merge master"
jgehw Feb 4, 2021
89a2e45
add uwp files to copy list
jgehw Feb 4, 2021
874c4b6
update uwppatch.h
jgehw Feb 4, 2021
79b3d50
fix typo
jgehw Feb 4, 2021
77b4118
patch the patch for UWP case
jgehw Feb 5, 2021
d513eb0
fix patch (missing spaces)
jgehw Feb 5, 2021
653a3bb
fix build error in AWS SDK prerequisit
jgehw Feb 6, 2021
c45bb8a
fix more compilation errors
jgehw Feb 10, 2021
9d14d06
replace previous patch with more targeted patch
jgehw Feb 10, 2021
f4192a8
add escaped quotes around Windows path with spaces
jgehw Feb 11, 2021
9ce008f
cleanup
jgehw Feb 11, 2021
52e0d0d
merge patch (there can only be one patch file per external)
jgehw Feb 11, 2021
0a91d3d
add messages to user
jgehw Feb 12, 2021
921c8ca
update versions files
jgehw Feb 22, 2021
583318d
update tensorflow to 2.4.1
jgehw Feb 22, 2021
c86bccb
port 0 seems to cause errors => remove port field
jgehw Feb 22, 2021
8f9464f
remove patches that made it into tensorflow, correct line numbers in …
jgehw Feb 22, 2021
769bdb3
fix patch line numbers, add copy rules for new header files
jgehw Feb 22, 2021
1eed553
fix patch line numbers
jgehw Feb 22, 2021
834556a
fix versions for x86
jgehw Feb 22, 2021
39f6797
add more Windows and Linux specific patches
jgehw Feb 22, 2021
12a6b95
add more Windows and Linux patches
jgehw Feb 23, 2021
a760cf6
fix UWP patches
jgehw Feb 23, 2021
95e5ce1
fix x86 target
jgehw Feb 23, 2021
4e82482
remove UWP specific fixes from this branch as UWP PR doesn't get merged
jgehw Mar 2, 2021
45851a6
fix version shas
jgehw Mar 2, 2021
fa73bec
Apply suggestions from code review
jgehw Mar 5, 2021
376ec11
fix version hash again
jgehw Mar 5, 2021
0a335b1
try an easier fix after discussion upstream
jgehw Mar 22, 2021
4fc1028
fix hashes
jgehw Mar 22, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ports/tensorflow-cc/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ vcpkg_fail_port_install(ON_ARCH "x86" "arm" ON_TARGET "UWP")

set(TF_LIB_SUFFIX "_cc")
set(TF_PORT_SUFFIX "-cc")
set(TF_INCLUDE_DIRS "${CURRENT_INSTALLED_DIR}/include/tensorflow-external
${CURRENT_INSTALLED_DIR}/include/tensorflow-external/src")
set(TF_INCLUDE_DIRS "${CURRENT_INSTALLED_DIR}/include/tensorflow-external ${CURRENT_INSTALLED_DIR}/include/tensorflow-external/src")
list(APPEND CMAKE_MODULE_PATH "${CURRENT_INSTALLED_DIR}/share/tensorflow-common")
include(tensorflow-common)

Expand Down
3 changes: 1 addition & 2 deletions ports/tensorflow-cc/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "tensorflow-cc",
"version-string": "2.3.1",
"port-version": 2,
"version-semver": "2.4.1",
"description": "Library for computation using data flow graphs for scalable machine learning (C++ API version)",
"homepage": "https://github.com/tensorflow/tensorflow",
"supports": "!(x86 | arm | uwp)",
Expand Down
11 changes: 5 additions & 6 deletions ports/tensorflow-common/change-macros-for-static-lib.patch
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ diff --git a/tensorflow/core/platform/macros.h b/tensorflow/core/platform/macros
diff --git a/tensorflow/c/c_api.h b/tensorflow/c/c_api.h
--- a/tensorflow/c/c_api.h
+++ b/tensorflow/c/c_api.h
@@ -70,24 +70,7 @@
@@ -71,24 +71,7 @@
// and the API just provides high level controls over the number of
// devices of each type.

Expand Down Expand Up @@ -81,7 +81,7 @@ diff --git a/tensorflow/c/c_api_experimental.h b/tensorflow/c/c_api_experimental
diff --git a/tensorflow/c/c_api_macros.h b/tensorflow/c/c_api_macros.h
--- a/tensorflow/c/c_api_macros.h
+++ b/tensorflow/c/c_api_macros.h
@@ -16,18 +16,6 @@
@@ -16,17 +16,5 @@
#ifndef TENSORFLOW_C_C_API_MACROS_H_
#define TENSORFLOW_C_C_API_MACROS_H_

Expand All @@ -99,14 +99,13 @@ diff --git a/tensorflow/c/c_api_macros.h b/tensorflow/c/c_api_macros.h
-#endif // _WIN32
-#endif // SWIG

#endif // TENSORFLOW_C_C_API_MACROS_H_

diff --git a/tensorflow/c/kernels.h b/tensorflow/c/kernels.h
--- a/tensorflow/c/kernels.h
+++ b/tensorflow/c/kernels.h
@@ -21,24 +21,7 @@
#include "tensorflow/c/tf_datatype.h"
@@ -23,24 +23,7 @@
#include "tensorflow/c/tf_status.h"
#include "tensorflow/c/tf_tensor.h"

-// Macro to control visibility of exported symbols in the shared library (.so,
-// .dylib, .dll).
Expand Down Expand Up @@ -210,7 +209,7 @@ diff --git a/tensorflow/c/tf_status.h b/tensorflow/c/tf_status.h
diff --git a/tensorflow/c/tf_tensor.h b/tensorflow/c/tf_tensor.h
--- a/tensorflow/c/tf_tensor.h
+++ b/tensorflow/c/tf_tensor.h
@@ -22,24 +22,7 @@
@@ -23,24 +23,7 @@
#include "tensorflow/c/tf_datatype.h"
#include "tensorflow/c/tf_status.h"

Expand Down
111 changes: 0 additions & 111 deletions ports/tensorflow-common/fix-dbg-build-errors.patch

This file was deleted.

68 changes: 8 additions & 60 deletions ports/tensorflow-common/fix-linux-build.patch
Original file line number Diff line number Diff line change
@@ -1,72 +1,20 @@
diff --git a/third_party/aws/aws-checksums.bazel b/third_party/aws/aws-checksums.bazel
--- a/third_party/aws/aws-checksums.bazel
+++ b/third_party/aws/aws-checksums.bazel
@@ -7,6 +7,13 @@

exports_files(["LICENSE"])

+load("@bazel_skylib//lib:selects.bzl", "selects")
+
+selects.config_setting_group(
+ name = "is_linux_debug",
+ match_all = ["@org_tensorflow//tensorflow:linux_x86_64", "@org_tensorflow//tensorflow:debug"],
+)
+
cc_library(
name = "aws-checksums",
srcs = select({
@@ -27,4 +34,10 @@
deps = [
"@aws-c-common",
],
+ defines = select({
+ ":is_linux_debug": [
+ "DEBUG_BUILD"
+ ],
+ "//conditions:default": [],
+ }),
)

diff --git a/tensorflow/core/kernels/data/experimental/io_ops.cc b/tensorflow/core/kernels/data/experimental/io_ops.cc
--- a/tensorflow/core/kernels/data/experimental/io_ops.cc
+++ b/tensorflow/core/kernels/data/experimental/io_ops.cc
@@ -28,6 +28,12 @@
namespace data {
namespace experimental {

+/*static*/ constexpr const char* const LoadDatasetOp::kCompression;
+/*static*/ constexpr const char* const LoadDatasetOp::kReaderFunc;
+/*static*/ constexpr const char* const LoadDatasetOp::kReaderFuncTarguments;
+
+/*static*/ constexpr const int SaveDatasetOp::kFileFormatVersion;
+
SaveDatasetOp::SaveDatasetOp(OpKernelConstruction* ctx)
: HybridAsyncOpKernel(ctx, "tf_data_save_dataset") {
OP_REQUIRES_OK(ctx, ctx->GetAttr(kCompression, &compression_));

diff --git a/tensorflow/core/kernels/data/experimental/snapshot_dataset_op.cc b/tensorflow/core/kernels/data/experimental/snapshot_dataset_op.cc
--- a/tensorflow/core/kernels/data/experimental/snapshot_dataset_op.cc
+++ b/tensorflow/core/kernels/data/experimental/snapshot_dataset_op.cc
@@ -63,6 +63,14 @@
namespace data {
namespace experimental {
@@ -72,6 +72,8 @@
SnapshotDatasetV2Op::kReaderFuncTarguments;
/* static */ constexpr const char* const
SnapshotDatasetV2Op::kShardFuncTarguments;
+/* static */ constexpr const char* const SnapshotDatasetV2Op::kReaderPrefix;
+/* static */ constexpr const char* const SnapshotDatasetV2Op::kWriterPrefix;
/* static */ constexpr const int SnapshotDatasetV2Op::kFileFormatVersion;

+/*static*/ constexpr const char* const SnapshotDatasetV2Op::kCompression;
+/*static*/ constexpr const char* const SnapshotDatasetV2Op::kReaderFunc;
+/*static*/ constexpr const char* const SnapshotDatasetV2Op::kShardFunc;
+/*static*/ constexpr const char* const SnapshotDatasetV2Op::kReaderFuncTarguments;
+/*static*/ constexpr const char* const SnapshotDatasetV2Op::kShardFuncTarguments;
+
+/*static*/ constexpr const int SnapshotDatasetV2Op::kFileFormatVersion;
+
// ==== Snapshot Implementation ====

/* The current snapshot on-disk layout is as follows:

diff --git a/tensorflow/core/kernels/data/experimental/data_service_dataset_op.cc b/tensorflow/core/kernels/data/experimental/data_service_dataset_op.cc
--- a/tensorflow/core/kernels/data/experimental/data_service_dataset_op.cc
+++ b/tensorflow/core/kernels/data/experimental/data_service_dataset_op.cc
@@ -52,6 +52,8 @@
@@ -53,6 +53,8 @@
/* static */ constexpr const char* const
DataServiceDatasetOp::kMaxOutstandingRequests;
/* static */ constexpr const char* const
Expand Down
11 changes: 0 additions & 11 deletions ports/tensorflow-common/fix-more-build-errors.patch

This file was deleted.

12 changes: 12 additions & 0 deletions ports/tensorflow-common/fix-windows-build.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
diff --git a/core/platform/default/logging.h b/core/platform/default/logging.h
--- a/tensorflow/core/platform/default/logging.h
+++ b/tensorflow/core/platform/default/logging.h
@@ -13,6 +13,8 @@
limitations under the License.
==============================================================================*/

+#pragma warning(disable:4716)
+
#ifndef TENSORFLOW_CORE_PLATFORM_DEFAULT_LOGGING_H_
#define TENSORFLOW_CORE_PLATFORM_DEFAULT_LOGGING_H_

3 changes: 1 addition & 2 deletions ports/tensorflow-common/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@ set(TENSORFLOW_FILES
"${CMAKE_CURRENT_LIST_DIR}/convert_lib_params_linux.py"
"${CMAKE_CURRENT_LIST_DIR}/convert_lib_params_windows.py"
"${CMAKE_CURRENT_LIST_DIR}/fix-build-error.patch"
"${CMAKE_CURRENT_LIST_DIR}/fix-dbg-build-errors.patch"
"${CMAKE_CURRENT_LIST_DIR}/fix-linux-build.patch"
"${CMAKE_CURRENT_LIST_DIR}/fix-more-build-errors.patch"
"${CMAKE_CURRENT_LIST_DIR}/fix-windows-build.patch"
"${CMAKE_CURRENT_LIST_DIR}/generate_static_link_cmd_linux.py"
"${CMAKE_CURRENT_LIST_DIR}/generate_static_link_cmd_macos.py"
"${CMAKE_CURRENT_LIST_DIR}/generate_static_link_cmd_windows.py"
Expand Down
13 changes: 8 additions & 5 deletions ports/tensorflow-common/tensorflow-common.cmake
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
set(TF_VERSION 2.3.1)
set(TF_VERSION_SHORT 2.3)
set(TF_VERSION 2.4.1)
set(TF_VERSION_SHORT 2.4)

vcpkg_find_acquire_program(BAZEL)
get_filename_component(BAZEL_DIR "${BAZEL}" DIRECTORY)
NancyLi1013 marked this conversation as resolved.
Show resolved Hide resolved
Expand Down Expand Up @@ -112,24 +112,27 @@ endif()
foreach(BUILD_TYPE dbg rel)
# prefer repeated source extraction here for each build type over extracting once above the loop and copying because users reported issues with copying symlinks
set(STATIC_ONLY_PATCHES)
set(WINDOWS_ONLY_PATCHES)
set(LINUX_ONLY_PATCHES)
if(VCPKG_LIBRARY_LINKAGE STREQUAL static)
set(STATIC_ONLY_PATCHES "${CMAKE_CURRENT_LIST_DIR}/change-macros-for-static-lib.patch") # there is no static build option - change macros via patch and link library manually at the end
endif()
if(VCPKG_TARGET_IS_WINDOWS)
set(WINDOWS_ONLY_PATCHES "${CMAKE_CURRENT_LIST_DIR}/fix-windows-build.patch")
endif()
if(VCPKG_TARGET_IS_LINUX)
set(LINUX_ONLY_PATCHES "${CMAKE_CURRENT_LIST_DIR}/fix-linux-build.patch")
endif()
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO tensorflow/tensorflow
REF "v${TF_VERSION}"
SHA512 e497ef4564f50abf9f918be4522cf702f4cf945cb1ebf83af1386ac4ddc7373b3ba70c7f803f8ca06faf2c6b5396e60b1e0e9b97bfbd667e733b08b6e6d70ef0
SHA512 be8273f464c1c1c392f3ab0190dbba36d56a0edcc7991c1a86f16604c859056d3188737d11c3b41ec7918e1cf46d13814c50c00be8f459dde9f0fb618740ee3c
HEAD_REF master
PATCHES
"${CMAKE_CURRENT_LIST_DIR}/fix-build-error.patch" # Fix namespace error
"${CMAKE_CURRENT_LIST_DIR}/fix-dbg-build-errors.patch" # Fix no return statement
"${CMAKE_CURRENT_LIST_DIR}/fix-more-build-errors.patch" # Fix no return statement
${STATIC_ONLY_PATCHES}
${WINDOWS_ONLY_PATCHES}
${LINUX_ONLY_PATCHES}
)

Expand Down
3 changes: 1 addition & 2 deletions ports/tensorflow-common/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "tensorflow-common",
"version-string": "2.3.1",
"port-version": 1,
"version-semver": "2.4.1",
"description": "This meta package holds common files for the C [tensorflow] and the C++ [tensorflow-cc] API version of TensorFlow but is not installable on its own.",
"homepage": "https://github.com/tensorflow/tensorflow"
}
4 changes: 4 additions & 0 deletions ports/tensorflow/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,16 @@ include(tensorflow-common)

file(COPY "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/bazel-bin/tensorflow/include/tensorflow/c/c_api.h" DESTINATION "${CURRENT_PACKAGES_DIR}/include/tensorflow/c")
file(COPY "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/bazel-bin/tensorflow/include/tensorflow/c/c_api_experimental.h" DESTINATION "${CURRENT_PACKAGES_DIR}/include/tensorflow/c")
file(COPY "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/bazel-bin/tensorflow/include/tensorflow/c/c_api_macros.h" DESTINATION "${CURRENT_PACKAGES_DIR}/include/tensorflow/c")
file(COPY "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/bazel-bin/tensorflow/include/tensorflow/c/tensor_interface.h" DESTINATION "${CURRENT_PACKAGES_DIR}/include/tensorflow/c")
file(COPY "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/bazel-bin/tensorflow/include/tensorflow/c/tf_attrtype.h" DESTINATION "${CURRENT_PACKAGES_DIR}/include/tensorflow/c")
file(COPY "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/bazel-bin/tensorflow/include/tensorflow/c/tf_datatype.h" DESTINATION "${CURRENT_PACKAGES_DIR}/include/tensorflow/c")
file(COPY "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/bazel-bin/tensorflow/include/tensorflow/c/tf_file_statistics.h" DESTINATION "${CURRENT_PACKAGES_DIR}/include/tensorflow/c")
file(COPY "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/bazel-bin/tensorflow/include/tensorflow/c/tf_status.h" DESTINATION "${CURRENT_PACKAGES_DIR}/include/tensorflow/c")
file(COPY "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/bazel-bin/tensorflow/include/tensorflow/c/tf_tensor.h" DESTINATION "${CURRENT_PACKAGES_DIR}/include/tensorflow/c")
file(COPY "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/bazel-bin/tensorflow/include/tensorflow/c/tf_tstring.h" DESTINATION "${CURRENT_PACKAGES_DIR}/include/tensorflow/c")
file(COPY "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/bazel-bin/tensorflow/include/tensorflow/c/eager/c_api.h" DESTINATION "${CURRENT_PACKAGES_DIR}/include/tensorflow/c/eager")
file(COPY "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/bazel-bin/tensorflow/include/tensorflow/c/eager/c_api_experimental.h" DESTINATION "${CURRENT_PACKAGES_DIR}/include/tensorflow/c/eager")
file(COPY "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/bazel-bin/tensorflow/include/tensorflow/c/eager/dlpack.h" DESTINATION "${CURRENT_PACKAGES_DIR}/include/tensorflow/c/eager")
file(COPY "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/bazel-bin/tensorflow/include/tensorflow/core/platform/ctstring.h" DESTINATION "${CURRENT_PACKAGES_DIR}/include/tensorflow/core/platform")
file(COPY "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/bazel-bin/tensorflow/include/tensorflow/core/platform/ctstring_internal.h" DESTINATION "${CURRENT_PACKAGES_DIR}/include/tensorflow/core/platform")
3 changes: 1 addition & 2 deletions ports/tensorflow/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "tensorflow",
"version-string": "2.3.1",
"port-version": 1,
"version-semver": "2.4.1",
"description": "Library for computation using data flow graphs for scalable machine learning (C API version)",
"homepage": "https://github.com/tensorflow/tensorflow",
"supports": "!(x86 | arm | uwp)",
Expand Down
12 changes: 6 additions & 6 deletions versions/baseline.json
Original file line number Diff line number Diff line change
Expand Up @@ -5693,16 +5693,16 @@
"port-version": 0
},
"tensorflow": {
"baseline": "2.3.1",
"port-version": 1
"baseline": "2.4.1",
"port-version": 0
},
"tensorflow-cc": {
"baseline": "2.3.1",
"port-version": 2
"baseline": "2.4.1",
"port-version": 0
},
"tensorflow-common": {
"baseline": "2.3.1",
"port-version": 1
"baseline": "2.4.1",
"port-version": 0
},
"termcolor": {
"baseline": "1.0.1",
Expand Down
5 changes: 5 additions & 0 deletions versions/t-/tensorflow-cc.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "868e7ae57409669692df84ddb446f4a235e0b220",
"version-semver": "2.4.1",
"port-version": 0
},
{
"git-tree": "08a9ef525187b9b3656a686f2e83100643b7389e",
"version-string": "2.3.1",
Expand Down
Loading