[vcpkg baseline][poppler] Add feature splash and add its dependency boost-container and boost-move#16356
Merged
strega-nil merged 3 commits intomicrosoft:masterfrom Feb 24, 2021
Conversation
JackBoosY
added
category:port-bug
JackBoosY
changed the title
PhoebeHui
approved these changes
Feb 22, 2021
PhoebeHui
added
the
info:needs-maintainer-attention
ras0219
approved these changes
Feb 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
ENABLE_SPLASHis enabled (the default isON), poppler will look forboost, and when ANY component of boost is found, boost will be enabled, but the source code does not add the name of the component to look for boost, resulting in compilation failure:See source code https://github.com/freedesktop/poppler/blob/061bae27a04684bdb0a1b4a6c3a8adf7fddcb7db/splash/SplashXPathScanner.h#L30-L32