[scripts audit] vcpkg_copy_pdbs#16309
Closed
strega-nil wants to merge 2 commits intomicrosoft:masterfrom
Closed
Conversation
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Hey @PhoebeHui, do you know what's going on with itpp:*-uwp? did that just break or something? |
Contributor
|
@strega-nil. I will take a look the failures. |
Contributor
|
@strega-nil, I could repro this issue locally, it can't find the fft package, FFT_INCLUDES was set to NOTFOUND, so it configured fail when use the FFT_INCLUDES, I have submmited PR #16385 to fix it. |
* pull the cmake doc comment parsing out into its own function * support cmake helper ports * add real support for deprecation, as opposed to ad-hoc
strega-nil
force-pushed
the
scripts-audit/vcpkg_copy_pdbs
branch
from
d307846 to
c23919a
Compare
Contributor
Author
|
Closing in favor of a single PR that contains all of these PRs. (to avoid destroying the CI system) |
strega-nil
added a commit
to strega-nil/vcpkg
that referenced
this pull request
Feb 26, 2021
Audit vcpkg_copy_pdbs
strega-nil
added a commit
that referenced
this pull request
Feb 28, 2021
* [scripts-audit rollup] PR #16419 * pull the cmake doc comment parsing out into its own function * support cmake helper ports * add real support for deprecation, as opposed to ad-hoc * [scripts-audit rollup] PR #16192 * add a z_ in front of internal functions * move internal functions out set feature_vars again in parent scope * [scripts-audit rollup] PR #16309 Audit vcpkg_copy_pdbs * [scripts-audit rollup] PR #16304 * Fix usage, documentation * [scripts-audit rollup] PR #16393 * [scripts-audit rollup] PR #16377 Deprecate `vcpkg_*_cmake` in favor of `vcpkg_cmake_*` from the `vcpkg-cmake` port, as well as `vcpkg_fixup_cmake_targets` in favor of `vcpkg_cmake_config_fixup` from the `vcpkg-cmake-config` port.
51 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See scripts-audit, issue #16188
Part of the "merge 2021-02-26 EOD" group.