Skip to content

[sqlite3] Update to 3.34.1#16125

Merged
ras0219-msft merged 4 commits intomicrosoft:masterfrom
past-due:sqlite_3_34_1
Feb 24, 2021
Merged

[sqlite3] Update to 3.34.1#16125
ras0219-msft merged 4 commits intomicrosoft:masterfrom
past-due:sqlite_3_34_1

Conversation

@past-due
Copy link
Copy Markdown
Contributor

@past-due past-due commented Feb 8, 2021

Update sqlite3 port to 3.34.1: https://sqlite.org/releaselog/3_34_1.html

@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Feb 9, 2021
@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Feb 9, 2021

Hi @past-due

Thanks for your PR.

LGTM. Have you tested these features in this PR?

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Feb 9, 2021

All features have passed with the following triplets:

  • x86-windows
  • x64-windows-static

@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Feb 9, 2021
@ras0219-msft
Copy link
Copy Markdown
Contributor

ras0219-msft commented Feb 9, 2021

LGTM, thanks for the PR!

@ras0219-msft
Copy link
Copy Markdown
Contributor

ras0219-msft commented Feb 11, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Feb 11, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@ras0219-msft
Copy link
Copy Markdown
Contributor

ras0219-msft commented Feb 11, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Feb 11, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Feb 18, 2021 

1>D:\buildtrees\3fd\x64-windows-rel\c67c0b275c-accfc8aba3.clean\3FD\broker.h(11,10): fatal error C1083: Cannot open include file: 'Poco/Data/Session.h': No such file or directory (compiling source file broker_impl_writer.cpp) [D:\buildtrees\3fd\x64-windows-rel\c67c0b275c-accfc8aba3.clean\3FD\3FD.vcxproj]
     1>D:\buildtrees\3fd\x64-windows-rel\c67c0b275c-accfc8aba3.clean\3FD\broker.h(11,10): fatal error C1083: Cannot open include file: 'Poco/Data/Session.h': No such file or directory (compiling source file broker_impl_reader.cpp) [D:\buildtrees\3fd\x64-windows-rel\c67c0b275c-accfc8aba3.clean\3FD\3FD.vcxproj]
     1>D:\buildtrees\3fd\x64-windows-rel\c67c0b275c-accfc8aba3.clean\3FD\broker.h(11,10): fatal error C1083: Cannot open include file: 'Poco/Data/Session.h': No such file or directory (compiling source file broker_impl.cpp) [D:\buildtrees\3fd\x64-windows-rel\c67c0b275c-accfc8aba3.clean\3FD\3FD.vcxproj]
         isam_impl_database.cpp
         isam_impl_databaseconn.cpp
         isam_impl_errorhelper.cpp
     1>D:\buildtrees\3fd\x64-windows-rel\c67c0b275c-accfc8aba3.clean\3FD\logger.h(10,14): fatal error C1083: Cannot open include file: 'Poco/Logger.h': No such file or directory (compiling source file callstacktracer.cpp) [D:\buildtrees\3fd\x64-windows-rel\c67c0b275c-accfc8aba3.clean\3FD\3FD.vcxproj]
     1>D:\buildtrees\3fd\x64-windows-rel\c67c0b275c-accfc8aba3.clean\3FD\cmdline.h(6,10): fatal error C1083: Cannot open include file: 'boost/regex.hpp': No such file or directory (compiling source file cmdline.cpp) [D:\buildtrees\3fd\x64-windows-rel\c67c0b275c-accfc8aba3.clean\3FD\3FD.vcxproj]
         isam_impl_instance.cpp
         isam_impl_recordreader.cpp
     1>D:\buildtrees\3fd\x64-windows-rel\c67c0b275c-accfc8aba3.clean\3FD\xml.h(6,10): fatal error C1083: Cannot open include file: 'rapidxml/rapidxml.hpp': No such file or directory (compiling source file configuration.cpp) [D:\buildtrees\3fd\x64-windows-rel\c67c0b275c-accfc8aba3.clean\3FD\3FD.vcxproj]
         isam_impl_session.cpp

@NancyLi1013 NancyLi1013 removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Feb 18, 2021
@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Feb 19, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Feb 19, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Feb 20, 2021
@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Feb 20, 2021

After rerun, all CI checks have passed now.

@ras0219-msft ras0219-msft merged commit 6e8aaa7 into microsoft:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ras0219-msft ras0219-msft ras0219-msft approved these changes

+1 more reviewer

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@past-due @NancyLi1013 @ras0219-msft