Update DXUT port and add Effects11 (FX) port#16101
Update DXUT port and add Effects11 (FX) port#16101ras0219-msft merged 20 commits intomicrosoft:masterfrom walbourn:dxutfx11
Conversation
|
Validated with all supported triplets:
|
ras0219-msft
left a comment
There was a problem hiding this comment.
Awesome, thanks for the PR!
LGTM once my two suggestions are applied.
|
Seems the format for vcpkg.json is not correct. Could you please use |
|
@NancyLi1013 It didn't like having a port-version of 0 in the vcpkg.json... Fixed. |
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
|
@NancyLi1013 So I've fixed all the issues with dxut and effects11, sync'd master, and rebased. The remaining failure isn't my port: |
|
Merged #16138 so that should fix that failure... |
|
@ras0219-msft @NancyLi1013 I believe at this point all your feedback has been integrated. Please approve. |
|
Yep, this is great! Thanks for the new versions and the update PR! |
This updates the existing DXUT port to the latest version (it was last updated to the September 2016 release). The upstream project was updated with it's own CMake project and package support to simplify this port.
Also added a new Effects11 port for the Effects system for Direct3D 11. Again, the upstream project now provides a CMake.