Skip to content

[openvdb] Fix vcpkg-cmake-wrapper#15902

Merged
dan-shaw merged 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/15901
Jan 28, 2021
Merged

[openvdb] Fix vcpkg-cmake-wrapper#15902
dan-shaw merged 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/15901

Conversation

@JackBoosY
Copy link
Contributor

Add option OPENVDB_USE_STATIC_LIBS to cmake wrapper since FindOpenVDB.cmake use that.

Fixes #15901.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Jan 27, 2021
@JackBoosY
Copy link
Contributor Author

@Fedr Can you please test this PR?

Thanks.

@JackBoosY JackBoosY requested a review from NancyLi1013 January 27, 2021 08:21
Copy link

@Fedr Fedr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for a prompt fix, this solves my issue!

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 28, 2021
@dan-shaw dan-shaw merged commit 2928667 into microsoft:master Jan 28, 2021
@JackBoosY JackBoosY deleted the dev/jack/15901 branch January 28, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

openvdb: cmake get_prerequisites error

4 participants