Skip to content

[baseline][colmap] Fix find dependency freeimage#15886

Merged
dan-shaw merged 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix_colmap_freeimage
Jan 28, 2021
Merged

[baseline][colmap] Fix find dependency freeimage#15886
dan-shaw merged 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix_colmap_freeimage

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY commented Jan 26, 2021

The default find method only find the release version of freeimage.

Related: #15860.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Jan 26, 2021
@JackBoosY JackBoosY requested a review from NancyLi1013 January 26, 2021 09:17
@JackBoosY JackBoosY changed the title [colmap] Fix find dependency freeimage [baseline][colmap] Fix find dependency freeimage Jan 26, 2021
@JackBoosY JackBoosY mentioned this pull request Jan 26, 2021
Merged
@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 26, 2021
@Neumann-A
Copy link
Copy Markdown
Contributor

Neumann-A commented Jan 26, 2021

you might also want to pass GMP_LIBRARY=<somepath>/gmpd.lib via OPTIONS_DEBUG so that GMP in debug gets linked (Could be a windows only detail).
Small tip to analyse build logs: search|grep for installed/<triplet>/debug/lib in release builds and installed/<triplet>/lib in debug builds to discover wrong lib linkage.

@JackBoosY JackBoosY removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 26, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Jan 27, 2021

@Neumann-A I think the dependency cgal cannot be built successfully.
Because cgal depends on mpfr and mpir, while mpfr depends on gmp, and there is a conflict between gmp and mpir.
So we can ignore this point for now.

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 27, 2021
@Neumann-A
Copy link
Copy Markdown
Contributor

Neumann-A commented Jan 27, 2021

@JackBoosY If you look into CGAL you actually see a FindGMP. mpir is just mentioned there in a find_library call as a gmp replacement. That is why #15860 switches the dependency mpir to gmp. The problem is that that find_library call is not configuration aware there and always links the release lib of gmp since the debug version has a debug suffix (gmpd).

@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Jan 27, 2021

@Neumann-A Yep, but I can't test it in the master branch, so I suggest fix this after your PR merge.

@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Jan 28, 2021

Ping @dan-shaw for merge this PR quickly. Some PRs require this PR.

@dan-shaw dan-shaw merged commit 09fbac7 into microsoft:master Jan 28, 2021
@JackBoosY JackBoosY deleted the dev/jack/fix_colmap_freeimage branch January 28, 2021 02:27
@Adela0814 Adela0814 mentioned this pull request Jan 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JackBoosY @Neumann-A @NancyLi1013 @dan-shaw