Skip to content

[OpenCV] bump to 4.5.1 and to 3.4.13#15859

Merged
dan-shaw merged 12 commits intomicrosoft:masterfrom
cenit:dev/cenit/opencv451
Jan 29, 2021
Merged

[OpenCV] bump to 4.5.1 and to 3.4.13#15859
dan-shaw merged 12 commits intomicrosoft:masterfrom
cenit:dev/cenit/opencv451

Conversation

@cenit
Copy link
Contributor

@cenit cenit commented Jan 25, 2021

Fixes: #11875
Depends on: #15788
(in order to continue tests and debug, I have integrated also quirc fixes from PR above)

@cenit cenit marked this pull request as ready for review January 25, 2021 14:57
@cenit
Copy link
Contributor Author

cenit commented Jan 25, 2021

I cannot reproduce the OpenMVG regression on linux locally.
Any help is appreciated.

@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label Jan 26, 2021
@NancyLi1013
Copy link
Contributor

Found the following errors:
Error: While reading versions for port opencv from file: C:\a\1\s\versions\o-\opencv.json
       Local port version `4.5.1` exists in version file but it's not the first entry in the "versions" array.
Error: While reading versions for port opencv3 from file: C:\a\1\s\versions\o-\opencv3.json
       Local port version `3.4.13` exists in version file but it's not the first entry in the "versions" array.
Error: While reading versions for port opencv4 from file: C:\a\1\s\versions\o-\opencv4.json
       Local port version `4.5.1` exists in version file but it's not the first entry in the "versions" array.

To attempt to resolve all errors at once, run:

    vcpkg x-add-version --all

Seems need to update version again. @cenit

@cenit
Copy link
Contributor Author

cenit commented Jan 27, 2021

I am sure I did it many times. But merging with master which contained an older version on my branch which already added a newer version made this problem.
Maybe the problem was merging with master, I should have rebased? I will try my best to fix the problems

@cenit cenit force-pushed the dev/cenit/opencv451 branch from 5205531 to b441dc3 Compare January 27, 2021 07:26
@NancyLi1013
Copy link
Contributor

Currently, the versions will check every time once there are changes, which is annoying. But we have no better way to solve this.

All checks have passed now. Is necessary to test these features in this PR?

@cenit
Copy link
Contributor Author

cenit commented Jan 27, 2021

there is a vcpkg-ci-opencv port which should be already testing all reasonable features in all triplets.
Please check that CI really tested opencv in all configs, then we should be ready

@NancyLi1013
Copy link
Contributor

Seems CI didn't test all ports. I will rerun to retrigger CI.

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cenit
Copy link
Contributor Author

cenit commented Jan 27, 2021

@NancyLi1013 why is CI rebuilding everything?
Also, regression on uwp is clearly not due to this PR... must be something already on master!

@NancyLi1013
Copy link
Contributor

@cenit

I'm not sure why CI rebuild everything. I just renew the latest commit to retrigger CI since ports seem to be not built before.

For the regressions, I only know armadillo failed with downloading source codes since there is something wrong with the sever.

Other failures need to be checked whether these are problems for the ports or CI problems.

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cenit
Copy link
Contributor Author

cenit commented Jan 28, 2021

@NancyLi1013 can you retrigger again? The error on x64-osx was a filesystem one, should disappear if retried.

@NancyLi1013
Copy link
Contributor

All checks have passed now.

Thanks again for your contribution @cenit.

@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 29, 2021
@dan-shaw dan-shaw merged commit eb044d1 into microsoft:master Jan 29, 2021
@cenit cenit deleted the dev/cenit/opencv451 branch January 29, 2021 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[opencv3] patch to vcpkg build of 3.4.7-2

4 participants