[spirv-cross,spirv-headers,spirv-tools] 2021-01-15 update

[barcharcraz]

Describe the pull request

• update spirv-tools to version 2020.6
• update spirv-headers to version 1.5.4.raytracing.fixed (a required update to get spirv-tools to build)
• update spirv-cross to version 2021-01-15

Additionally removed several no-longer-needed patches from spirv-tools.

I think that spirv-tools and spirv-cross actually will build shared libs on windows now, but I have not gone and gotten that working.

[JackBoosY]

Most of them are good, but I have some questions:

1. spirv-cross generated additional cmake configuration files share/spirv_cross_c/cmake/spirv_cross_cConfig.cmake, they should be deleted.
2. spirv-tools generated two pkgconfig lib/pkgconfig/SPIRV-Tools-shared.pc and lib/pkgconfig/SPIRV-Tools.pc at the same time. Is this expected?
3. spirv-tools generated shared library lib/libSPIRV-Tools-shared.so on x64-linux, that should be incorrect.
4. Note glslang generates spirv binary and header files(include/SPIRV/GLSL.ext.AMD.h, lib/SPIRV.lib and tools/spirv-remap.exe), which may conflict with spirv hidden files or violate our policy (use the internal port of vcpkg instead of generating a separate copy).

[barcharcraz]

why should we delete the config files from spirv-cross?

I'll check the package config files later today

why is the library incorrect on linux, I didn't touch the library names at all and I don't want to force the package to generate libraries with a linuxey name if it doesn't do that on it's own (I don't want to change the library names from upstream).

[barcharcraz]

also I didn't touch glslang, I will check if spirv has an embedded dependency on glslang, but if not I'm not sure how to proceed there. I don't want to modify either package if they both generate those headers from the glsl specification xml.

[JackBoosY]

why should we delete the config files from spirv-cross?

Because all cmake configuration files should be installed in share/NAME, so I guess vcpkg_fixup_cmake_targets(CONFIG_PATH share/spirv_cross_c/cmake TARGET_PATH share/spirv_cross_c) is missing in spirv-cross's portfile.cmake.

why is the library incorrect on linux

Becuase our triplet x64-linux is a static triplet, all libraries should be built as static.

also I didn't touch glslang

Yes, glslang's issue doesn't related to your changes, I just notify it.

[barcharcraz]

@JackBoosY I have addressed the review comments, and also moved to a newer version of spirv-tools which required a newer (non released!) version of spirv-headers, I wrote the version as the date I accessed the repo.

[JackBoosY]

Waiting for merge #16904.