Fix #15395: libarchive build fails for x86_windows_v120#15799
Fix #15395: libarchive build fails for x86_windows_v120#15799Olernov wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Build fails on compiling xxhash.c having a fuction with "inline" specifier. "inline" is a c99 keyword and c99 is not yet (fully) supported with MSVC toolset v120: "The inline keyword is available only in C++. The __inline and __forceinline keywords are available in both C and C++. For compatibility with previous versions, _inline is a synonym for __inline." (Source: http://msdn.microsoft.com/en-us/library/z8y1yy88.aspx) This fix adds a patch that replaces "inline" with "__inline" in xxhash.c
|
Hi @Olernov, thanks for this PR! Thanks. |
|
Ok, submitted: |
|
Waiting for official reply. |
|
Libarchive has accepted the pull request libarchive/libarchive#1487. Probably the fix will be included into the next release. |
JackBoosY
left a comment
There was a problem hiding this comment.
Please bump the port version. See documentation.
Also please run command vcpkg x-add-version --all then commit the changes.
|
I think we should better wait for the next release of libarchive and then bump the port version, what do you think? |
|
@Olernov Fine. |
|
So, the upstream merged your changes, can you please merge your branch to master and run |
|
Opened a new PR for this: #20133 |
Build fails on compiling xxhash.c having a fuction with "inline" specifier.
"inline" is a c99 keyword and c99 is not yet (fully) supported with MSVC toolset v120:
"The inline keyword is available only in C++. The __inline and __forceinline
keywords are available in both C and C++. For compatibility with previous versions,
_inline is a synonym for __inline."
(Source: http://msdn.microsoft.com/en-us/library/z8y1yy88.aspx)
This fix adds a patch that replaces "inline" with "__inline" in xxhash.c
Describe the pull request
What does your PR fix? Fixes #
Which triplets are supported/not supported? Have you updated the CI baseline?
Does your PR follow the maintainer guide?