Skip to content

[msys2] Update msys components pkgconfig url#15732

Merged
dan-shaw merged 3 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/15726
Jan 22, 2021
Merged

[msys2] Update msys components pkgconfig url#15732
dan-shaw merged 3 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/15726

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY commented Jan 18, 2021

Fixes #15726.

@JackBoosY JackBoosY added info:internal category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly labels Jan 18, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Jan 18, 2021

@wangweiwei1188 Can you please test this PR?

Thanks.

@wangweiwei1188
Copy link
Copy Markdown

wangweiwei1188 commented Jan 18, 2021

@wangweiwei1188 Can you please test this PR?

Thanks.

OK, I will do it.

wangweiwei1188
wangweiwei1188 approved these changes Jan 18, 2021
View reviewed changes
Copy link
Copy Markdown

@wangweiwei1188 wangweiwei1188 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's well done.

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Jan 19, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Jan 19, 2021

Waiting for #15740.

@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Jan 20, 2021
@JackBoosY JackBoosY changed the title [pkgconfig] Update msys components pkgconfig url [msys2] Update msys components pkgconfig url Jan 20, 2021
@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 21, 2021
ras0219
ras0219 approved these changes Jan 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ras0219 ras0219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the changes[1] to the package and determined that this is an acceptable upgrade -- in the future, this is likely to need to move to a port for better version management.

However, I'm unable to repro the issue linked -- we have many different mirrors listed for a reason, and (for example) https://www2.futureware.at/~nickoe/msys2-mirror/mingw/i686/mingw-w64-i686-pkg-config-0.29.2-1-any.pkg.tar.xz succeeds for me.

[1] https://github.com/msys2/MSYS2-packages/commits/master/pkg-config

@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Jan 21, 2021

@ras0219 You can remove downloads/tools/msys2 and rerpo this issue by installing x264:x64-uwp.

@dan-shaw dan-shaw merged commit f0997d3 into microsoft:master Jan 22, 2021
@JackBoosY JackBoosY deleted the dev/jack/15726 branch January 25, 2021 02:41
@JackBoosY JackBoosY mentioned this pull request Mar 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

+2 more reviewers

@ras0219 ras0219 ras0219 approved these changes

@wangweiwei1188 wangweiwei1188 wangweiwei1188 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PhoebeHui PhoebeHui

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Package: zlib:x64-windows-static

5 participants

@JackBoosY @wangweiwei1188 @ras0219 @PhoebeHui @dan-shaw