Skip to content

[poppler] Disable clang-format check#15727

Merged
dan-shaw merged 9 commits intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/fix-poppler
Jan 22, 2021
Merged

[poppler] Disable clang-format check#15727
dan-shaw merged 9 commits intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/fix-poppler

Conversation

@NancyLi1013
Copy link
Copy Markdown
Contributor

@NancyLi1013 NancyLi1013 commented Jan 18, 2021

Describe the pull request

  • What does your PR fix? Fixes #

clang-format.exe cannot be found now, So disable clang-format.

'clang-format' is not recognized as an internal or external command,
operable program or batch file.
'true' is not recognized as an internal or external command,
operable program or batch file.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Jan 18, 2021
@JackBoosY JackBoosY marked this pull request as draft January 18, 2021 09:21
@NancyLi1013 NancyLi1013 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Jan 18, 2021
@NancyLi1013 NancyLi1013 changed the title [poppler] Disable clang-format check [vcpkg] Add clang-format tool Jan 19, 2021
@NancyLi1013
Copy link
Copy Markdown
Contributor Author

The regressions caused by gettext will be fixed by PR #15740

@JackBoosY JackBoosY added depends:different-pr This PR or Issue depends on a PR which has been filed and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Jan 19, 2021
@NancyLi1013 NancyLi1013 marked this pull request as ready for review January 21, 2021 07:40
@NancyLi1013 NancyLi1013 added the depends:vm-update PR contains changes to the VM provisioning scripts label Jan 21, 2021
@NancyLi1013
Copy link
Copy Markdown
Contributor Author

cc @BillyONeal

@NancyLi1013
Copy link
Copy Markdown
Contributor Author

Currently, I have added clang-format. Seems it needs to be installed on our CI machine.

CMake Error at scripts/cmake/vcpkg_find_acquire_program.cmake:566 (message):
  Could not find clang-format.  Please install it via your package manager:

      sudo apt-get install clang-format

@BillyONeal
Copy link
Copy Markdown
Member

Rather than trying to provide clang-format I think we should be patching out whatever uses it in poppler's build system.

@strega-nil strega-nil force-pushed the dev/NancyLi/fix-poppler branch from 4e2a668 to e62612a Compare January 21, 2021 18:31
@NancyLi1013
Copy link
Copy Markdown
Contributor Author

Thanks for your suggestion @BillyONeal. I will revert this changes about clang-format.

@NancyLi1013 NancyLi1013 changed the title [vcpkg] Add clang-format tool [poppler] Disable clang-format check Jan 22, 2021
@NancyLi1013 NancyLi1013 removed category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly depends:vm-update PR contains changes to the VM provisioning scripts labels Jan 22, 2021
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 22, 2021
@dan-shaw dan-shaw merged commit ab0acc7 into microsoft:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants