[poppler] Disable clang-format check#15727
Merged
dan-shaw merged 9 commits intomicrosoft:masterfrom Jan 22, 2021
Merged
Conversation
JackBoosY
approved these changes
Jan 18, 2021
NancyLi1013
commented
Jan 19, 2021
Contributor
Author
|
The regressions caused by gettext will be fixed by PR #15740 |
Contributor
Author
|
cc @BillyONeal |
Contributor
Author
|
Currently, I have added |
Member
|
Rather than trying to provide clang-format I think we should be patching out whatever uses it in poppler's build system. |
4e2a668 to
e62612a
Compare
Contributor
Author
|
Thanks for your suggestion @BillyONeal. I will revert this changes about clang-format. |
added 3 commits
January 21, 2021 21:47
…013/vcpkg into dev/NancyLi/fix-poppler
JackBoosY
approved these changes
Jan 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
clang-format.execannot be found now, So disable clang-format.